Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg:add_packages into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 6c3c8511a5decf369318c04b865f508d9d279f30
Merged at revision: 51040366b5da099db44bd4f8a203a7a48e1cc639
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg:add_packages
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg:master
Diff against target: 23 lines (+5/-0)
1 file modified
snap/snapcraft.yaml (+5/-0)
Reviewer Review Type Date Requested Status
Vic Liu Approve
Rick Wu Approve
StanleyHuang Pending
PeiYao Chang Pending
Review via email: mp+456226@code.launchpad.net

Commit message

Add some build-packages for snap building and linuxptp back temporarily due to issue not fixed

Add 3 more necessary build packages for building
 - python3-packaging
 - python3-urwid
 - python3-xlsxwriter
 - python3-requests-oauthlib

Add linuxptp package back temporarily due to the issue #12 [1] is still not fixed. Hence we need the commands from debian package `linuxptp` to temporarily substitue the commands from snap `linuxptp-rt`.
This package will be removed one the issue is resolved.

[1] https://github.com/canonical/linuxptp-snap/issues/12

To post a comment you must log in.
Revision history for this message
Rick Wu (rickwu4444) wrote :

LGTM

review: Approve
Revision history for this message
Vic Liu (zongminl) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 7bb8e22..9b178f6 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -103,6 +103,7 @@ parts:
6 - vainfo
7 - rt-tests # provides cyclictest for RT performance testing
8 - sshpass # used for tsn testing to connect to tsn server
9+ - linuxptp # temporarily used for tsn testing, since the issue #12 on https://github.com/canonical/linuxptp-snap hasn't been fixed
10 build-attributes: [no-patchelf]
11 build-snaps:
12 - checkbox22
13@@ -114,6 +115,10 @@ parts:
14 python3 manage.py install --layout=relocatable --prefix=/providers/checkbox-provider-intliotg --root="$SNAPCRAFT_PART_INSTALL"
15 build-packages:
16 - python3-jinja2
17+ - python3-packaging
18+ - python3-urwid
19+ - python3-xlsxwriter
20+ - python3-requests-oauthlib
21 tsn-tools:
22 plugin: nil
23 build-packages:

Subscribers

People subscribed via source and target branches