Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:remove_tsn-talker_listener into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 37dde8054375354cc44bfc539cf75079007fd31b
Merged at revision: de561c5c6b62c6fbb559484890fb0d6cd24dce3f
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:remove_tsn-talker_listener
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 15 lines (+0/-4)
1 file modified
snap/snapcraft.yaml (+0/-4)
Reviewer Review Type Date Requested Status
Vic Liu Approve
PeiYao Chang Approve
Weichen Wu Pending
StanleyHuang Pending
Rick Wu Pending
Review via email: mp+465392@code.launchpad.net

Commit message

Remove tsn-talker and tsn-listener

Description of the change

Since the previous refactoring [1] not using tsn-talker and tsn-listener, we remove them from snapcraft.yaml

[1] https://code.launchpad.net/~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg/+merge/465123

To post a comment you must log in.
Revision history for this message
PeiYao Chang (baconyao) wrote :

+1

review: Approve
Revision history for this message
Vic Liu (zongminl) wrote :

+1, thanks for the clean up

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 96dabcb..36647c2 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -87,10 +87,6 @@ parts:
6 - libc6-dev
7 override-build: |
8 mkdir -p ${SNAPCRAFT_PART_INSTALL}/usr/bin
9- gcc ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-talker.c -o ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-talker
10- cp -v ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-talker ${SNAPCRAFT_PART_INSTALL}/usr/bin/
11- gcc ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-listener.c -o ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-listener
12- cp -v ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/tsn-listener ${SNAPCRAFT_PART_INSTALL}/usr/bin/
13 gcc ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/udp_tai.c -o ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/udp_tai -lpthread
14 cp -v ${SNAPCRAFT_PROJECT_DIR}/parts/checkbox-provider-intliotg/src/src/udp_tai ${SNAPCRAFT_PART_INSTALL}/usr/bin/
15 parts-meta-info:

Subscribers

People subscribed via source and target branches