Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_packages into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 1727faf90016d026e2e1ebc37250c0e4c5462d49
Merged at revision: ec281ba21a7e8f14b354fdaab2bbafa93341598a
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_packages
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 12 lines (+1/-0)
1 file modified
snap/snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
PeiYao Chang Approve
Rick Wu Approve
StanleyHuang Pending
Weichen Wu Pending
Review via email: mp+465038@code.launchpad.net

Commit message

Add python library netifaces for future TSN testing

Description of the change

This could help us get the ethernet interface ip based on interface name.

To post a comment you must log in.
Revision history for this message
Rick Wu (rickwu4444) wrote :

LGTM

review: Approve
Revision history for this message
PeiYao Chang (baconyao) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index e9231e6..0df235b 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -79,6 +79,7 @@ parts:
6 - python3-urwid
7 - python3-xlsxwriter
8 - python3-requests-oauthlib
9+ - python3-netifaces
10 tsn-tools:
11 plugin: nil
12 build-packages:

Subscribers

People subscribed via source and target branches