Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_package_requests into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: b31e38441c5fc380e69d2739fc2b10aac035cfd1
Merged at revision: 3d614128848caa914be0fdaa67b0d20452f730eb
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_package_requests
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 12 lines (+1/-0)
1 file modified
snap/snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Rick Wu Approve
PeiYao Chang Approve
Vic Liu Pending
StanleyHuang Pending
Review via email: mp+456225@code.launchpad.net

Commit message

Add requests package for snapcraft build

Description of the change

We need this package to build snap

To post a comment you must log in.
Revision history for this message
PeiYao Chang (baconyao) wrote :

LGTM

review: Approve
Revision history for this message
Rick Wu (rickwu4444) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index c57b53e..e9231e6 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -78,6 +78,7 @@ parts:
6 - python3-packaging
7 - python3-urwid
8 - python3-xlsxwriter
9+ - python3-requests-oauthlib
10 tsn-tools:
11 plugin: nil
12 build-packages:

Subscribers

People subscribed via source and target branches