Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_build_and_staged_packages into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 740c97cb059789c4c02db5366f29178f5f221c83
Merged at revision: 862306fa313b032209816aa0a0bad674072487fd
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:add_build_and_staged_packages
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 22 lines (+4/-0)
1 file modified
snap/snapcraft.yaml (+4/-0)
Reviewer Review Type Date Requested Status
Patrick Liu (community) Approve
Vic Liu Approve
StanleyHuang Pending
Rick Wu Pending
PeiYao Chang Pending
Review via email: mp+456160@code.launchpad.net

Commit message

Add some build-packages for snap building and linuxptp back temporarily due to issue not fixed

Add 3 more necessary build packages for building
 - python3-packaging
 - python3-urwid
 - python3-xlsxwriter

Add linuxptp package back temporarily due to the issue #12 [1] is still not fixed. Hence we need the commands from debian package `linuxptp` to temporarily substitue the commands from snap `linuxptp-rt`.
This package will be removed one the issue is resolved.

[1] https://github.com/canonical/linuxptp-snap/issues/12

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

+1, thank you, but please also add this change to checkbox-iiotg snapcraft.yaml

review: Approve
Revision history for this message
Patrick Liu (patliu) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 76844be..c57b53e 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -63,6 +63,7 @@ parts:
6 - vainfo
7 - rt-tests # provides cyclictest for RT performance testing
8 - sshpass # used for tsn testing to connect to tsn server
9+ - linuxptp # temporarily used for tsn testing, since the issue #12 on https://github.com/canonical/linuxptp-snap hasn't been fixed
10 build-attributes: [no-patchelf]
11 build-snaps:
12 - checkbox22
13@@ -74,6 +75,9 @@ parts:
14 python3 manage.py install --layout=relocatable --prefix=/providers/checkbox-provider-intliotg --root="$SNAPCRAFT_PART_INSTALL"
15 build-packages:
16 - python3-jinja2
17+ - python3-packaging
18+ - python3-urwid
19+ - python3-xlsxwriter
20 tsn-tools:
21 plugin: nil
22 build-packages:

Subscribers

People subscribed via source and target branches