Merge ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:seperate_rt-performance-test_from_stress_test into ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 59b6dfdc0cb0e9111b3f4a36089880de14d4ba4f
Merged at revision: 6a618b801cd87d8d2adf81d92f1485a46a418980
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-iiotg-classic:seperate_rt-performance-test_from_stress_test
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-iiotg-classic:master
Diff against target: 48 lines (+4/-0)
4 files modified
launchers/test-runner-adl (+1/-0)
launchers/test-runner-ehl (+1/-0)
launchers/test-runner-rpl (+1/-0)
launchers/test-runner-tgl (+1/-0)
Reviewer Review Type Date Requested Status
Vic Liu Approve
PeiYao Chang Approve
StanleyHuang Pending
Rick Wu Pending
Patrick Liu Pending
Review via email: mp+446341@code.launchpad.net

Commit message

Modify: Seperate rt-performance-test from stress test
Related MR: https://code.launchpad.net/~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg/+merge/446342

To post a comment you must log in.
Revision history for this message
PeiYao Chang (baconyao) wrote :

LGTM

review: Approve
Revision history for this message
Vic Liu (zongminl) wrote :

I don't think this is the best implementation for rt-performance tests to be pulled into launcher, but to be honest I don't have a better solution now, let's merge it and revisit this later.
+1 to this change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launchers/test-runner-adl b/launchers/test-runner-adl
2index 20ea7c1..e4f11be 100755
3--- a/launchers/test-runner-adl
4+++ b/launchers/test-runner-adl
5@@ -22,6 +22,7 @@ filter = com.canonical.qa.intliotg::intliotg-desktop-22-04
6 com.canonical.qa.intliotg::intliotg-server-22-04-manual-rt
7 com.canonical.qa.intliotg::intliotg-server-22-04-automated-rt
8 com.canonical.qa.intliotg::intliotg-server-22-04-stress-rt
9+ com.canonical.qa.intliotg::rt-performance-tests-stress
10
11 [manifest]
12 com.canonical.certification::has_card_reader= false
13diff --git a/launchers/test-runner-ehl b/launchers/test-runner-ehl
14index 42ef654..db5eb20 100755
15--- a/launchers/test-runner-ehl
16+++ b/launchers/test-runner-ehl
17@@ -22,6 +22,7 @@ filter = com.canonical.qa.intliotg::intliotg-desktop-22-04
18 com.canonical.qa.intliotg::intliotg-server-22-04-manual-rt
19 com.canonical.qa.intliotg::intliotg-server-22-04-automated-rt
20 com.canonical.qa.intliotg::intliotg-server-22-04-stress-rt
21+ com.canonical.qa.intliotg::rt-performance-tests-stress
22
23 [manifest]
24 com.canonical.certification::has_audio_capture= false
25diff --git a/launchers/test-runner-rpl b/launchers/test-runner-rpl
26index e106f3e..0f16fd9 100755
27--- a/launchers/test-runner-rpl
28+++ b/launchers/test-runner-rpl
29@@ -22,6 +22,7 @@ filter = com.canonical.qa.intliotg::intliotg-desktop-22-04
30 com.canonical.qa.intliotg::intliotg-server-22-04-manual-rt
31 com.canonical.qa.intliotg::intliotg-server-22-04-automated-rt
32 com.canonical.qa.intliotg::intliotg-server-22-04-stress-rt
33+ com.canonical.qa.intliotg::rt-performance-tests-stress
34
35 [manifest]
36 com.canonical.certification::has_audio_capture= true
37diff --git a/launchers/test-runner-tgl b/launchers/test-runner-tgl
38index 3c8e951..5562664 100755
39--- a/launchers/test-runner-tgl
40+++ b/launchers/test-runner-tgl
41@@ -22,6 +22,7 @@ filter = com.canonical.qa.intliotg::intliotg-desktop-22-04
42 com.canonical.qa.intliotg::intliotg-server-22-04-manual-rt
43 com.canonical.qa.intliotg::intliotg-server-22-04-automated-rt
44 com.canonical.qa.intliotg::intliotg-server-22-04-stress-rt
45+ com.canonical.qa.intliotg::rt-performance-tests-stress
46
47 [manifest]
48 com.canonical.certification::has_audio_capture= true

Subscribers

People subscribed via source and target branches