Merge ~lgp171188/turnip:fix-logrotate-conf-turnip-api-two-service-reloads into turnip:master

[Guruprasad]

Use a single logrotate config block for turnip api log files

This fixes the issue of the turnip-api service getting reloaded twice, once for each log file specified.

LP: #2015860

[Colin Watson (cjwatson)]

We also need to add `sharedscripts`, conventionally just before `postrotate`. This causes the `postrotate` script to only be run once, rather than once per file.

review: Needs Fixing

[Colin Watson (cjwatson)]

review: Approve

diff --git a/charm/turnip-api/templates/logrotate.j2 b/charm/turnip-api/templates/logrotate.j2
index 17b96ea..a5d216c 100644
--- a/charm/turnip-api/templates/logrotate.j2
+++ b/charm/turnip-api/templates/logrotate.j2
@@ -1,17 +1,4 @@
-{{ base_dir }}/logs/turnip-api-access.log {
-    rotate 90
-    daily
-    dateext
-    delaycompress
-    compress
-    missingok
-    create 0644 {{ user }} {{ group }}
-    postrotate
-        service turnip-api reload
-    endscript
-}
-
-{{ base_dir }}/logs/turnip-api-error.log {
+{{ base_dir }}/logs/turnip-api-access.log {{ base_dir }}/logs/turnip-api-error.log {
     rotate 90
     daily
     dateext
@@ -19,6 +6,7 @@
     compress
     missingok
     create 0644 {{ user }} {{ group }}
+    sharedscripts
     postrotate
         service turnip-api reload
     endscript