Merge ~lgp171188/lazr.restful:add-launchpad-yaml into lazr.restful:main

Proposed by Guruprasad
Status: Needs review
Proposed branch: ~lgp171188/lazr.restful:add-launchpad-yaml
Merge into: lazr.restful:main
Diff against target: 86 lines (+37/-2)
4 files modified
.launchpad.yaml (+33/-0)
src/lazr/restful/docs/interface.rst (+0/-1)
src/lazr/restful/docs/webservice-declarations.rst (+0/-1)
tox.ini (+4/-0)
Reviewer Review Type Date Requested Status
LAZR Developers Pending
Review via email: mp+432546@code.launchpad.net

Commit message

Add a .launchpad.yaml file to auto-run tests in CI

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) :
Revision history for this message
Andrey Fedoseev (andrey-fedoseev) wrote :

The build is failing. I think we need to debug it locally, including the issues with pathon3.6 and lower.

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

I started debugging yesterday.

While I have not finished, I have some clues.

a) we need to add a `passenv = HOME` to the linter env in tox.ini.
That is a known issue, see this thread: https://chat.canonical.com/canonical/pl/qh4qniaehbfcbbuua1kdtyca4c

b) as Debian and thus Ubuntu splits Python into several packages, we need to also install `python3.x-distutils`

c) then the next error probably happens as the existing pyproject.yaml file implicitly triggers pip to do a PEP517 type build... I'd need to investigate what needs to be done to fix this, maybe updating some packages, or forcing pip to not do a PEP517 build ( python3 -m pip install --no-use-pep517 - that would require to update tox' install command)

98e0b11... by Guruprasad

Remove the IGNORE_EXCEPTION_MODULE_IN_PYTHON2 doctest option

5620770... by Guruprasad

Add a .launchpad.yaml file to auto-run tests in CI

2456614... by Guruprasad

Run the tests on Python 3.5-3.7 as well

Revision history for this message
Jürgen Gmach (jugmac00) wrote :
91d0df6... by Guruprasad

Add an 'install_command' to avoid using PEP-517-style builds

Unmerged commits

91d0df6... by Guruprasad

Add an 'install_command' to avoid using PEP-517-style builds

Failed
[SUCCEEDED] lint:0 (build)
[FAILED] test:0 (build)
[WAITING] coverage:0 (build)
13 of 3 results
2456614... by Guruprasad

Run the tests on Python 3.5-3.7 as well

5620770... by Guruprasad

Add a .launchpad.yaml file to auto-run tests in CI

98e0b11... by Guruprasad

Remove the IGNORE_EXCEPTION_MODULE_IN_PYTHON2 doctest option

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.launchpad.yaml b/.launchpad.yaml
2new file mode 100644
3index 0000000..98fb03f
4--- /dev/null
5+++ b/.launchpad.yaml
6@@ -0,0 +1,33 @@
7+pipeline:
8+ - lint
9+ - test
10+ - coverage
11+
12+jobs:
13+ lint:
14+ series: focal
15+ architectures: amd64
16+ packages:
17+ - tox
18+ - git
19+ snaps: [go]
20+ run: tox -e lint
21+ test:
22+ series: focal
23+ architectures: amd64
24+ package-repositories:
25+ - type: apt
26+ ppa: deadsnakes/ppa
27+ packages:
28+ - tox
29+ - python3.5
30+ - python3.6
31+ - python3.7
32+ - python3.9
33+ - python3.10
34+ run: tox -e py35,py36,py37,py38,py39,py310
35+ coverage:
36+ series: focal
37+ architectures: amd64
38+ packages: [tox]
39+ run: tox -e coverage
40diff --git a/src/lazr/restful/docs/interface.rst b/src/lazr/restful/docs/interface.rst
41index 1fdf251..d255024 100644
42--- a/src/lazr/restful/docs/interface.rst
43+++ b/src/lazr/restful/docs/interface.rst
44@@ -184,4 +184,3 @@ That function can only be called on an IField:
45 Traceback (most recent call last):
46 ...
47 TypeError: <...Attribute...> doesn't provide IField.
48-
49diff --git a/src/lazr/restful/docs/webservice-declarations.rst b/src/lazr/restful/docs/webservice-declarations.rst
50index 41826d7..258f3b6 100644
51--- a/src/lazr/restful/docs/webservice-declarations.rst
52+++ b/src/lazr/restful/docs/webservice-declarations.rst
53@@ -3198,4 +3198,3 @@ is accessible in every version.
54 <...POST_IBetaMutatorEntry3_set_value_beta...>
55 >>> operation_for(context, '3.0', 'set_value')
56 <...POST_IBetaMutatorEntry3_set_value_beta...>
57-
58diff --git a/tox.ini b/tox.ini
59index 4b07cac..c8a8dc1 100644
60--- a/tox.ini
61+++ b/tox.ini
62@@ -14,6 +14,8 @@ envlist =
63 deps =
64 .[test,xml]
65 zope.testrunner
66+passenv = http_proxy https_proxy
67+install_command = python -I -m pip install --no-use-pep517 {opts} {packages}
68 commands =
69 zope-testrunner --test-path src --tests-pattern ^tests {posargs}
70
71@@ -22,6 +24,7 @@ basepython = python3.8
72 deps =
73 pre-commit
74 skip_install = true
75+passenv = HOME http_proxy https_proxy
76 commands =
77 pre-commit run -a
78
79@@ -38,6 +41,7 @@ deps =
80 .[test,xml]
81 zope.testrunner
82 coverage
83+passenv = http_proxy https_proxy
84 commands =
85 coverage erase
86 coverage run -m zope.testrunner --test-path src --tests-pattern ^tests {posargs}

Subscribers

People subscribed via source and target branches