Merge ~lgp171188/launchpad:update-codehosting-ssh-public-port into launchpad:master

Proposed by Guruprasad
Status: Merged
Approved by: Guruprasad
Approved revision: 20e2f1bcbe68d6e704685db3907958ea5a1ff539
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~lgp171188/launchpad:update-codehosting-ssh-public-port
Merge into: launchpad:master
Diff against target: 29 lines (+6/-1)
2 files modified
charm/launchpad-codehosting/config.yaml (+5/-0)
charm/launchpad-codehosting/reactive/launchpad-codehosting.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+454732@code.launchpad.net

Commit message

charm: Update the bzr sftp port to 5022 and make it configurable

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-codehosting/config.yaml b/charm/launchpad-codehosting/config.yaml
2index 540b982..466edec 100644
3--- a/charm/launchpad-codehosting/config.yaml
4+++ b/charm/launchpad-codehosting/config.yaml
5@@ -97,6 +97,11 @@ options:
6 type: int
7 description: Base port number for the bzr-sftp service.
8 default: 2224
9+ port_lb_bzr_sftp:
10+ type: int
11+ description: |
12+ The port on the frontend load balancer to expose the bzr-sftp service on.
13+ default: 5022
14 port_web_status_base:
15 type: int
16 description: Base port for the web status service.
17diff --git a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
18index 3176027..e057de9 100644
19--- a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
20+++ b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
21@@ -373,7 +373,7 @@ def configure_frontend_loadbalancer():
22 },
23 {
24 "service_name": "launchpad-codehosting-ssh",
25- "service_port": 922,
26+ "service_port": config["port_lb_bzr_sftp"],
27 "service_host": "0.0.0.0",
28 "service_options": list(service_options_ssh),
29 "servers": [

Subscribers

People subscribed via source and target branches

to status/vote changes: