Merge ~lgp171188/launchpad:codespell-bugs into launchpad:master

Proposed by Guruprasad
Status: Merged
Approved by: Guruprasad
Approved revision: 6159f4f36f5192078d9439f57e9dabf463812136
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~lgp171188/launchpad:codespell-bugs
Merge into: launchpad:master
Diff against target: 157 lines (+15/-15)
10 files modified
lib/lp/bugs/browser/bugtarget.py (+1/-1)
lib/lp/bugs/doc/externalbugtracker-debbugs.rst (+1/-1)
lib/lp/bugs/externalbugtracker/mantis.py (+1/-1)
lib/lp/bugs/mail/tests/test_handler.py (+6/-6)
lib/lp/bugs/model/structuralsubscription.py (+1/-1)
lib/lp/bugs/model/vulnerability.py (+1/-1)
lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.rst (+1/-1)
lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.rst (+1/-1)
lib/lp/bugs/tests/externalbugtracker.py (+1/-1)
lib/lp/bugs/tests/test_bugnotification.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+437874@code.launchpad.net

Commit message

Fix spelling errors in lp.bugs

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Guruprasad (lgp171188) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/browser/bugtarget.py b/lib/lp/bugs/browser/bugtarget.py
2index ed93035..0d7f4af 100644
3--- a/lib/lp/bugs/browser/bugtarget.py
4+++ b/lib/lp/bugs/browser/bugtarget.py
5@@ -858,7 +858,7 @@ class FileBugViewBase(LaunchpadFormView):
6 default_bug_reported_acknowledgement = "Thank you for your bug report."
7
8 def getAcknowledgementMessage(self, context):
9- """An acknowlegement message displayed to the user."""
10+ """An acknowledgement message displayed to the user."""
11 # If a given context does not have a custom message, we go up in the
12 # "object hierarchy" until we find one. If no customized messages
13 # exist for any context, a default message is returned.
14diff --git a/lib/lp/bugs/doc/externalbugtracker-debbugs.rst b/lib/lp/bugs/doc/externalbugtracker-debbugs.rst
15index b26f84f..80bd099 100644
16--- a/lib/lp/bugs/doc/externalbugtracker-debbugs.rst
17+++ b/lib/lp/bugs/doc/externalbugtracker-debbugs.rst
18@@ -206,7 +206,7 @@ there's no way of knowing if the bug is confirmed or not.
19 New
20
21 If the 'wontfix' tag is present we map it to "Won't Fix". The 'wontfix'
22-tag takes precedence over the confimed tags (help, confirmed, upstream,
23+tag takes precedence over the confirmed tags (help, confirmed, upstream,
24 fixed-upstream) since 'wontfix' is the state after confirmed. The 'wontfix'
25 tag also takes precedence over the fix-committed tags (pending, fixed,
26 fixed-in-experimental) since the malone status will correctly change to
27diff --git a/lib/lp/bugs/externalbugtracker/mantis.py b/lib/lp/bugs/externalbugtracker/mantis.py
28index 9c6083b..9554143 100644
29--- a/lib/lp/bugs/externalbugtracker/mantis.py
30+++ b/lib/lp/bugs/externalbugtracker/mantis.py
31@@ -448,7 +448,7 @@ class Mantis(ExternalBugTracker):
32 ("assigned", BugTaskStatus.INPROGRESS),
33 ("feedback", BugTaskStatus.INCOMPLETE),
34 ("new", BugTaskStatus.NEW),
35- ("confirmed", "ackowledged", BugTaskStatus.CONFIRMED),
36+ ("confirmed", "acknowledged", BugTaskStatus.CONFIRMED),
37 (
38 "resolved",
39 "closed",
40diff --git a/lib/lp/bugs/mail/tests/test_handler.py b/lib/lp/bugs/mail/tests/test_handler.py
41index fd60ba1..c193437 100644
42--- a/lib/lp/bugs/mail/tests/test_handler.py
43+++ b/lib/lp/bugs/mail/tests/test_handler.py
44@@ -307,14 +307,14 @@ class MaloneHandlerProcessTestCase(TestCaseWithFactory):
45 handler = MaloneHandler()
46 with person_logged_in(project.owner):
47 msg = self.factory.makeSignedMessage(
48- body="unsecure\n security yes\n affects fnord\n tag ajax",
49- subject="unsecure code",
50+ body="insecure\n security yes\n affects fnord\n tag ajax",
51+ subject="insecure code",
52 to_address="new@bugs.launchpad.test",
53 )
54 handler.process(msg, msg["To"])
55 notification = self.getLatestBugNotification()
56 bug = notification.bug
57- self.assertEqual("unsecure code", bug.title)
58+ self.assertEqual("insecure code", bug.title)
59 self.assertTrue(bug.security_related)
60 self.assertEqual(["ajax"], bug.tags)
61 self.assertEqual(1, len(bug.bugtasks))
62@@ -354,14 +354,14 @@ class MaloneHandlerProcessTestCase(TestCaseWithFactory):
63 handler = MaloneHandler()
64 with person_logged_in(project.owner):
65 msg = self.factory.makeSignedMessage(
66- body="unsecure\n informationtype userdata\n affects fnord",
67- subject="unsecure code",
68+ body="insecure\n informationtype userdata\n affects fnord",
69+ subject="insecure code",
70 to_address="new@bugs.launchpad.test",
71 )
72 handler.process(msg, msg["To"])
73 notification = self.getLatestBugNotification()
74 bug = notification.bug
75- self.assertEqual("unsecure code", bug.title)
76+ self.assertEqual("insecure code", bug.title)
77 self.assertEqual(InformationType.USERDATA, bug.information_type)
78 self.assertEqual(1, len(bug.bugtasks))
79 self.assertEqual(project, bug.bugtasks[0].target)
80diff --git a/lib/lp/bugs/model/structuralsubscription.py b/lib/lp/bugs/model/structuralsubscription.py
81index dff0e8f..a5c9519 100644
82--- a/lib/lp/bugs/model/structuralsubscription.py
83+++ b/lib/lp/bugs/model/structuralsubscription.py
84@@ -750,7 +750,7 @@ def _get_structural_subscription_filter_id_query(
85 # we can get the full set of what we need in subsuming or
86 # subsequent SQL calls.
87 # (Aside 1: We could in theory get all the fields we wanted with
88- # a hack--we could use an aggregrate function like max to get
89+ # a hack--we could use an aggregate function like max to get
90 # fields that we know will be unique--but Storm would not like
91 # it.)
92 # (Aside 2: IMO Postgres should allow getting other fields if
93diff --git a/lib/lp/bugs/model/vulnerability.py b/lib/lp/bugs/model/vulnerability.py
94index 846ea55..53eef9d 100644
95--- a/lib/lp/bugs/model/vulnerability.py
96+++ b/lib/lp/bugs/model/vulnerability.py
97@@ -434,7 +434,7 @@ def get_vulnerability_privacy_filter(user):
98 access to, including private vulnerabilities where the user has proper
99 permission.
100
101- :param user: An IPerson, or a class attribute tha references an IPerson
102+ :param user: An IPerson, or a class attribute that references an IPerson
103 in the database.
104 :return: A Storm condition.
105 """
106diff --git a/lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.rst b/lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.rst
107index c664ab9..5b02254 100644
108--- a/lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.rst
109+++ b/lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.rst
110@@ -85,7 +85,7 @@ The whole comment is visible on this page:
111 itemprop="commentText"><p>This would be a real killer feature.
112 If there is already code
113 to make it possible, why aren't there tons of press announcements
114- about the secuirty possibilities. Imagine - no more embarrassing
115+ about the security possibilities. Imagine - no more embarrassing
116 emails for ... disappear! I'm sure Redmond will switch over as soon as
117 they hear about this. It's not a bug, it's a feature!</p></div>
118 </div>
119diff --git a/lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.rst b/lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.rst
120index 67eb70a..ccf9feb 100644
121--- a/lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.rst
122+++ b/lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-guidelines.rst
123@@ -2,7 +2,7 @@ Bug Reporting Guidelines and acknowledgement messages
124 =====================================================
125
126 Some helpful explanatory text - guidelines - can be set for
127-distributions, product groups, products, and source packages, as wel
128+distributions, product groups, products, and source packages, as well
129 as an acknowledgement message that is displayed when a bug has been
130 filed.
131
132diff --git a/lib/lp/bugs/tests/externalbugtracker.py b/lib/lp/bugs/tests/externalbugtracker.py
133index 6a126b5..e0e84db 100644
134--- a/lib/lp/bugs/tests/externalbugtracker.py
135+++ b/lib/lp/bugs/tests/externalbugtracker.py
136@@ -1521,7 +1521,7 @@ class TestTracXMLRPCTransport(RequestsTransport):
137 for bug in bugs_to_return
138 ]
139 # At level 3, we return the full comment dicts along with the
140- # bug metadata. Tne comment dicts do not include the user field,
141+ # bug metadata. The comment dicts do not include the user field,
142 # however.
143 elif level == LP_PLUGIN_FULL:
144 bugs_to_return = [
145diff --git a/lib/lp/bugs/tests/test_bugnotification.py b/lib/lp/bugs/tests/test_bugnotification.py
146index 063c64c..47f764e 100644
147--- a/lib/lp/bugs/tests/test_bugnotification.py
148+++ b/lib/lp/bugs/tests/test_bugnotification.py
149@@ -397,7 +397,7 @@ class TestNotificationsLinkToFilters(TestCaseWithFactory):
150
151
152 class TestNotificationProcessingWithoutRecipients(TestCaseWithFactory):
153- """Adding notificatons without any recipients does not cause any harm.
154+ """Adding notifications without any recipients does not cause any harm.
155
156 In some cases, we may have attempts to send bug notifications for bugs
157 that do not have any notification recipients.

Subscribers

People subscribed via source and target branches

to status/vote changes: