Merge ~lgp171188/launchpad:launchpad-og-image-fix into launchpad:master

Proposed by Guruprasad
Status: Merged
Approved by: Guruprasad
Approved revision: c0e455ac9a03bacb7410964a276e0e57760d3aa3
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~lgp171188/launchpad:launchpad-og-image-fix
Merge into: launchpad:master
Diff against target: 17 lines (+1/-1)
1 file modified
lib/lp/app/templates/base-layout.pt (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Jürgen Gmach Approve
Review via email: mp+422976@code.launchpad.net

Commit message

Add a higher resolution image for og:image

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :
Revision history for this message
Jürgen Gmach (jugmac00) :
review: Approve
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/canonical/launchpad/images/launchpad-og-image.png b/lib/canonical/launchpad/images/launchpad-og-image.png
2new file mode 100644
3index 0000000..fb0f9c8
4Binary files /dev/null and b/lib/canonical/launchpad/images/launchpad-og-image.png differ
5diff --git a/lib/lp/app/templates/base-layout.pt b/lib/lp/app/templates/base-layout.pt
6index 5e2d7a3..86b4ee9 100644
7--- a/lib/lp/app/templates/base-layout.pt
8+++ b/lib/lp/app/templates/base-layout.pt
9@@ -62,7 +62,7 @@
10 condition="python: getattr(view, 'show_opengraph_meta', True)">
11 <meta property="og:title" tal:attributes="content view/fmt:pagetitle" />
12 <meta property="og:type" content="website" />
13- <meta property="og:image" content="/@@/launchpad.png" />
14+ <meta property="og:image" content="/@@/launchpad-og-image.png" />
15 <meta property="og:url" tal:attributes="content python: view.recommended_canonical_url or request.URL" />
16 <meta property="og:site_name" content="Launchpad" />
17 </tal:opengraph>

Subscribers

People subscribed via source and target branches

to status/vote changes: