Merge ~lgp171188/launchpad-mojo-specs:grant-ppa-publisher-logs-access-to-ubuntu-archive-administrators into launchpad-mojo-specs:master

Proposed by Guruprasad
Status: Merged
Approved by: Guruprasad
Approved revision: 1f8f2a39dfb35f051c9eb58eb7296ff0a5ad0299
Merged at revision: 1f8f2a39dfb35f051c9eb58eb7296ff0a5ad0299
Proposed branch: ~lgp171188/launchpad-mojo-specs:grant-ppa-publisher-logs-access-to-ubuntu-archive-administrators
Merge into: launchpad-mojo-specs:master
Diff against target: 25 lines (+2/-1)
2 files modified
lp/bundle.yaml (+1/-1)
lp/configs/custom-secgroups-production.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+464409@code.launchpad.net

Commit message

Allow Ubuntu archive administrators access to PPA publisher logs

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :
Revision history for this message
Ines Almeida (ines-almeida) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lp/bundle.yaml b/lp/bundle.yaml
2index 5a04a65..e19a439 100644
3--- a/lp/bundle.yaml
4+++ b/lp/bundle.yaml
5@@ -642,7 +642,7 @@
6 gpg_upload_keys: "{{ gpg_upload_keys }}"
7 http_proxy: "{{ http_proxy }}"
8 is_demo: "{{ is_demo }}"
9-{%- if stage_name == "production" and application.startswith("launchpad-ftpmaster-") %}
10+{%- if stage_name == "production" and (application.startswith("launchpad-ftpmaster-") or application == "launchpad-ppa-publisher") %}
11 # Ubuntu release team members and Ubuntu archive administrators have a legitimate
12 # interest in reading ftpmaster logs.
13 log_hosts_allow: "{{ log_hosts_allow }} ubuntu-release-bastion-ps5.internal ubuntu-archive-bastion-ps5.internal"
14diff --git a/lp/configs/custom-secgroups-production.yaml b/lp/configs/custom-secgroups-production.yaml
15index 2dceb4e..b856aec 100644
16--- a/lp/configs/custom-secgroups-production.yaml
17+++ b/lp/configs/custom-secgroups-production.yaml
18@@ -81,6 +81,7 @@ applications:
19 rules:
20 - ppa-lb-http-access
21 - rsync-logs
22+ - rsync-logs-ubuntu-archive
23 launchpad-ppa-uploader:
24 type: neutron
25 rules:

Subscribers

People subscribed via source and target branches