Merge ~lgp171188/launchpad-mojo-specs:fix-broken-primary-archive-site into launchpad-mojo-specs:master

Proposed by Guruprasad
Status: Needs review
Proposed branch: ~lgp171188/launchpad-mojo-specs:fix-broken-primary-archive-site
Merge into: launchpad-mojo-specs:master
Diff against target: 20 lines (+9/-0)
1 file modified
lp-archive/bundle.yaml (+9/-0)
Reviewer Review Type Date Requested Status
Clinton Fung Approve
Review via email: mp+464344@code.launchpad.net

Commit message

Fix the broken HTTP version of the primary host site

Now there is an HTTPS-only version of that site, without a redirect from
HTTP to HTTPS, and an HTTP-only version of the same site. With this, we
have the site on both HTTP and HTTPS, without the former redirecting to
the latter.

To post a comment you must log in.
Revision history for this message
Clinton Fung (clinton-fung) wrote :

Looks good, thanks!

review: Approve

Unmerged commits

2be2a23... by Guruprasad

Fix the broken HTTP version of the primary host site

Now there is an HTTPS-only version of that site, without a redirect from
HTTP to HTTPS, and an HTTP-only version of the same site. With this, we
have the site on both HTTP and HTTPS, without the former redirecting to
the latter.

Succeeded
[SUCCEEDED] lint:0 (build)
11 of 1 result

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lp-archive/bundle.yaml b/lp-archive/bundle.yaml
2index 95a85c0..46ef3b6 100644
3--- a/lp-archive/bundle.yaml
4+++ b/lp-archive/bundle.yaml
5@@ -145,6 +145,15 @@ applications:
6 - real_ip_header X-Forwarded-For
7 - allow 127.0.0.1
8 - deny all
9+ # We need the following configuration to have separate
10+ # HTTP and HTTPS versions of the primary host's site,
11+ # with the former *not* redirecting to the latter.
12+ # The key below creates an HTTP-only version of the site.
13+ {{ primary_host }}:
14+ <<: *ARCHIVE_SITE
15+ tls-cert-bundle-path: ""
16+ # The key below creates an HTTPS-only version of the site
17+ # without a corresponding redirect from HTTP to HTTPS.
18 {{ primary_host }}:
19 <<: *ARCHIVE_SITE
20 redirect-http-to-https: false

Subscribers

People subscribed via source and target branches