Merge lp:~lfaraone/vmbuilder/lp580237 into lp:vmbuilder

Proposed by Luke Faraone
Status: Merged
Merged at revision: 450
Proposed branch: lp:~lfaraone/vmbuilder/lp580237
Merge into: lp:vmbuilder
Diff against target: 15 lines (+2/-3)
1 file modified
VMBuilder/plugins/virtualbox/vm.py (+2/-3)
To merge this branch: bzr merge lp:~lfaraone/vmbuilder/lp580237
Reviewer Review Type Date Requested Status
Soren Hansen Approve
Review via email: mp+25624@code.launchpad.net

Description of the change

This branch fixes LP: #580237 by updating the way the VirtualBox plugin adds settings.

To post a comment you must log in.
Revision history for this message
Soren Hansen (soren) :
review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

Looks good, thank you! Sorry about the delay.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'VMBuilder/plugins/virtualbox/vm.py'
2--- VMBuilder/plugins/virtualbox/vm.py 2010-02-25 08:57:20 +0000
3+++ VMBuilder/plugins/virtualbox/vm.py 2010-05-19 17:12:29 +0000
4@@ -32,9 +32,8 @@
5 arg = 'vbox'
6
7 def register_options(self):
8- group = self.context.setting_group('VirtualBox options')
9- group.add_option('--vbox-disk-format', metavar='FORMAT', default='vdi', help='Desired disk format. Valid options are: vdi vmdk. [default: %default]')
10- self.context.register_setting_group(group)
11+ group = self.setting_group('VM settings')
12+ group.add_setting('vbox-disk-format', metavar='FORMAT', default='vdi', help='Desired disk format. Valid options are: vdi vmdk. [default: %default]')
13
14 def finalize(self):
15 self.imgs = []

Subscribers

People subscribed via source and target branches