Merge lp:~lfaraone/launchpad/bugfix494055 into lp:launchpad

Proposed by Luke Faraone
Status: Merged
Approved by: Edwin Grubbs
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~lfaraone/launchpad/bugfix494055
Merge into: lp:launchpad
Diff against target: 25 lines (+2/-2)
2 files modified
lib/lp/bugs/doc/bugtracker.txt (+1/-1)
lib/lp/bugs/model/bugtracker.py (+1/-1)
To merge this branch: bzr merge lp:~lfaraone/launchpad/bugfix494055
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) code Approve
Review via email: mp+15903@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Hi Luke,

The bug tracker url fix looks good, and the test passes. I will work on landing this (merging into trunk) for you tomorrow.

merge-approved

-Edwin

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/doc/bugtracker.txt'
2--- lib/lp/bugs/doc/bugtracker.txt 2009-10-04 11:53:15 +0000
3+++ lib/lp/bugs/doc/bugtracker.txt 2009-12-10 00:33:20 +0000
4@@ -442,7 +442,7 @@
5 >>> links = example_google_code.getBugFilingAndSearchLinks(
6 ... remote_product='testproduct', summary="Foo", description="Bar")
7 >>> print_links(links)
8- bug_filing_url: http://.../issues/entry?summary=Foo&comment=Bar
9+ bug_filing_url: http://.../issues/entry?summary=Foo&comment=Bar
10 bug_search_url: http://.../issues/list?q=Foo
11
12 Trac's bug filing form doesn't accept data in the query string, so we don't
13
14=== modified file 'lib/lp/bugs/model/bugtracker.py'
15--- lib/lp/bugs/model/bugtracker.py 2009-10-04 11:53:15 +0000
16+++ lib/lp/bugs/model/bugtracker.py 2009-12-10 00:33:20 +0000
17@@ -179,7 +179,7 @@
18 "%(base_url)s/enter_bug.cgi?product=%(remote_product)s"
19 "&short_desc=%(summary)s&long_desc=%(description)s"),
20 BugTrackerType.GOOGLE_CODE: (
21- "%(base_url)s/entry?summary=%(summary)s&"
22+ "%(base_url)s/entry?summary=%(summary)s&"
23 "comment=%(description)s"),
24 BugTrackerType.MANTIS: (
25 "%(base_url)s/bug_report_advanced_page.php"