Merge lp:~lepistone/web-addons/6.1-web_export_view-many2many into lp:~webaddons-core-editors/web-addons/6.1

Proposed by Leonardo Pistone
Status: Merged
Merged at revision: 16
Proposed branch: lp:~lepistone/web-addons/6.1-web_export_view-many2many
Merge into: lp:~webaddons-core-editors/web-addons/6.1
Diff against target: 21 lines (+5/-3)
1 file modified
web_export_view/static/js/web_advanced_export.js (+5/-3)
To merge this branch: bzr merge lp:~lepistone/web-addons/6.1-web_export_view-many2many
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Lorenzo Battistini (community) Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+165578@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

LGTM

review: Approve
Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'web_export_view/static/js/web_advanced_export.js'
2--- web_export_view/static/js/web_advanced_export.js 2013-01-28 16:50:08 +0000
3+++ web_export_view/static/js/web_advanced_export.js 2013-05-24 11:31:48 +0000
4@@ -66,12 +66,14 @@
5 view = this.widget_parent; // valid for list view
6 if (view.widget_children) {
7 view.widget_children.every(function(child) {
8- if (child.field && (
9- child.field.type == 'many2many'
10- || child.field.type == 'one2many')) {
11+ if (child.field && child.field.type == 'one2many') {
12 view = child.viewmanager.views.list.controller;
13 return false; // break out of the loop
14 }
15+ if (child.field && child.field.type == 'many2many') {
16+ view = child.list_view;
17+ return false; // break out of the loop
18+ }
19 return true;
20 });
21 }

Subscribers

People subscribed via source and target branches