lptools

Merge lp:~leonardr/lptools/multiversion-support into lp:~dobey/lptools/trunk

  1. multiversion-support
  2. Merge into trunk
Proposed by Leonard Richardson on 2010-03-31
Status: Merged
Approved by: dobey on 2010-04-23
Approved revision: 13
Merged at revision: not available
Proposed branch: lp:~leonardr/lptools/multiversion-support
Merge into: lp:~dobey/lptools/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
bin/lp-review-list (+1/-1)
To merge this branch: bzr merge lp:~leonardr/lptools/multiversion-support
Reviewer Review Type Date Requested Status
dobey 2010-03-31 Approve on 2010-04-23
Robert Collins (community) Approve on 2010-04-09
Review via email: mp+22544@code.launchpad.net

Commit Message

Generalized the regular expression to work with any version of the web service.

Description of the Change

This branch generalizes the "beta" out of a regular expression so that the lp-review-list script will work against any version of the Launchpad web service (in particular, the '1.0' version, which is about to become the launchpadlib default).

To post a comment you must log in.
Robert Collins (lifeless) wrote :

It looks fine to me.

review: Approve
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/lp-review-list'
2--- bin/lp-review-list 2010-03-11 22:04:30 +0000
3+++ bin/lp-review-list 2010-03-31 15:22:27 +0000
4@@ -281,7 +281,7 @@
5 status = "%s\n%s" % (c.source_branch.display_name,
6 vstr)
7 urlp = re.compile(
8- 'http[s]?://api\.(.*)launchpad\.net/beta/')
9+ 'http[s]?://api\.(.*)launchpad\.net/[^/]+/')
10 merge_url = urlp.sub(
11 'http://launchpad.net/', c.self_link)
12

Subscribers

People subscribed via source and target branches

to all changes: