Merge lp:~leonardr/lazr.restfulclient/delete-entry into lp:lazr.restfulclient

[Leonard Richardson]

This branch rectifies a major oversight: there was no non-hacky way to DELETE a lazr.restful entry resource from lazr.restfulclient.

To get the tests to work I had to create
https://code.edge.launchpad.net/~leonardr/lazr.restful/fix-remove-recipe.

[Leonard Richardson (leonardr)]

Oh: I originally wanted to implement __del__ instead of lp_delete, but upon reading the documentation I saw that __del__ deletes the _variable_ assignment, not necessarily the underlying object. So it's not an appropriate overload.

[Leonard Richardson (leonardr)]

The fix-remove-recipe branch seems not to be necessary--there was an intermittent problem with my setup that's now gone away.

[Leonard Richardson (leonardr)]

Diff: http://pastebin.ubuntu.com/427014/

[Aaron Bentley (abentley)]

review: Approve

[lp:~leonardr/lazr.restfulclient/delete-entry]

102. By Leonard Richardson on 2010-05-03

Updated release date.

=== modified file 'src/lazr/restfulclient/NEWS.txt'
--- src/lazr/restfulclient/NEWS.txt	2010-04-27 19:18:57 +0000
+++ src/lazr/restfulclient/NEWS.txt	2010-05-03 16:45:39 +0000
@@ -2,13 +2,16 @@
 NEWS for lazr.restfulclient
 ===========================
 
-0.9.16 (2010-04-27)
+0.9.16 (2010-05-03)
 ===================
 
  - If a server returns a 502 or 503 error code, lazr.restfulclient
    will retry its request a configurable number of times in hopes that
    the error is transient.
 
+ - It's now possible to invoke lazr.restful destructor methods, with
+   the lp_delete() method.
+
 0.9.15 (2010-04-27)
 ====================
 

=== modified file 'src/lazr/restfulclient/_browser.py'
--- src/lazr/restfulclient/_browser.py	2010-04-29 13:17:40 +0000
+++ src/lazr/restfulclient/_browser.py	2010-05-03 16:45:39 +0000
@@ -355,6 +355,7 @@
     def delete(self, url):
         """DELETE the resource at the given URL."""
         self._request(url, method='DELETE')
+        return None
 
     def patch(self, url, representation, headers=None):
         """PATCH the object at url with the updated representation."""

=== modified file 'src/lazr/restfulclient/docs/entries.txt'
--- src/lazr/restfulclient/docs/entries.txt	2010-04-14 19:02:48 +0000
+++ src/lazr/restfulclient/docs/entries.txt	2010-05-03 16:45:39 +0000
@@ -469,3 +469,28 @@
     ...
     ValueError: You tried to access a resource that you don't have the
     server-side permission to see.
+
+Deleting an entry
+=================
+
+Some entries can be deleted with the lp_delete method.
+
+    >>> recipe = service.recipes[6]
+    >>> print recipe.lp_delete()
+    None
+
+A deleted entry no longer exists.
+
+    >>> recipe.lp_refresh()
+    Traceback (most recent call last):
+    ...
+    HTTPError: HTTP Error 404: Not Found
+    ...
+
+Some entries can't be deleted.
+
+    >>> cookbook.lp_delete()
+    Traceback (most recent call last):
+    ...
+    HTTPError: HTTP Error 405: Method Not Allowed
+    ...

=== modified file 'src/lazr/restfulclient/resource.py'
--- src/lazr/restfulclient/resource.py	2010-04-27 19:16:14 +0000
+++ src/lazr/restfulclient/resource.py	2010-05-03 16:45:39 +0000
@@ -609,6 +609,10 @@
         return '<%s at %s>' % (
             URI(self.resource_type_link).fragment, self.self_link)
 
+    def lp_delete(self):
+        """Delete the resource."""
+        return self._root._browser.delete(URI(self.self_link))
+
     def __str__(self):
         """Return the URL to the resource."""
         return self.self_link