Merge lp:~leonardr/lazr.restful/web-link-wadl into lp:lazr.restful
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | 158 |
Merged at revision: | 169 |
Proposed branch: | lp:~leonardr/lazr.restful/web-link-wadl |
Merge into: | lp:lazr.restful |
Diff against target: |
233 lines (+84/-24) 5 files modified
src/lazr/restful/_resource.py (+12/-8) src/lazr/restful/docs/webservice.txt (+10/-6) src/lazr/restful/tales.py (+4/-0) src/lazr/restful/templates/wadl-root.pt (+7/-0) src/lazr/restful/tests/test_webservice.py (+51/-10) |
To merge this branch: | bzr merge lp:~leonardr/lazr.restful/web-link-wadl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+47404@code.launchpad.net |
Description of the change
My earlier lazr.restful branches added a web_link field to certain representations of entries. This branch finishes off the feature by adding the web_link field to the WADL description of every entry that supports it.
The changes to webservice.txt are necessary, even though they don't change the test, because WADL generation will no longer succeed unless every entry class has a publish_web_link annotation.
The test_wadl_
Hi Leonard,
Thanks for this branch. I found one small problem with it, which we discussed on IRC:
[15:42] gmb:
leonardr: In your diff it looks like there's a missing or extra single quote:
[15:43] gmb:
113+ <param style="plain" name="web_link" path="$[web_link']"
[15:43] gmb:
(specifically $[web_link'])
[15:43] leonardr:
gmb, thanks
Also, some of the formatting in the doctest was a bit confusing to me, so I've produced a patch that should take care of it (you don't have to apply this to land it, it's just a suggestion): http:// pastebin. ubuntu. com/558144/ plain/.