Merge lp:~leonardr/lazr.restful/fix-remove-recipe into lp:lazr.restful

[Leonard Richardson]

This very simple branch adds 'removeRecipe' to the list of "require" attributes for Cookbook, so that the Zope security proxy allows that method to be called. Without this change, lazr.restfulclient can't DELETE a recipe.

Why is there no test? Because I can't figure out why the existing tests pass. The same code runs whether we test DELETE in lazr.restful or lazr.restfulclient. I don't see why the Zope security proxy shouldn't be running in the lazr.restful tests, but clearly it hasn't been.

Is this mystery worth resolving right now?

[Leonard Richardson (leonardr)]

This seems not to have been necessary--presumably it wasn't a real problem or was resolved some other way.

review: Disapprove

Unmerged revisions

128. By Leonard Richardson on 2010-04-29

Initial representation.

=== modified file 'src/lazr/restful/NEWS.txt'
--- src/lazr/restful/NEWS.txt	2010-04-14 15:04:35 +0000
+++ src/lazr/restful/NEWS.txt	2010-04-29 13:39:23 +0000
@@ -2,6 +2,12 @@
 NEWS for lazr.restful
 =====================
 
+0.9.26 (2010-04-29)
+===================
+
+Corrected a bit of ZCML that was causing lazr.restfulclient test
+failures.
+
 0.9.25 (2010-04-14)
 ===================
 

=== modified file 'src/lazr/restful/example/base/configure.zcml'
--- src/lazr/restful/example/base/configure.zcml	2009-09-01 14:37:41 +0000
+++ src/lazr/restful/example/base/configure.zcml	2010-04-29 13:39:23 +0000
@@ -6,8 +6,6 @@
   <webservice:register module="lazr.restful.example.base.interfaces" />
   <grok:grok package="lazr.restful.example.base" />
 
-  <!--Security configuration-->
-
   <permission id="lazr.restful.example.base.View" title="Viewing something" />
   <permission id="lazr.restful.example.base.ViewPrivate"
    title="Viewing private information" />
@@ -20,7 +18,7 @@
     <require attributes="name copyright_date cover cuisine description
                          recipes find_recipe_for find_recipes last_printing
                          make_more_interesting price replace_cover
-                         revision_number get"
+                         revision_number get removeRecipe"
              set_attributes="name copyright_date cover cuisine description
                              last_printing price revision_number"
              permission="zope.Public" />

=== modified file 'src/lazr/restful/version.txt'
--- src/lazr/restful/version.txt	2010-04-13 21:07:08 +0000
+++ src/lazr/restful/version.txt	2010-04-29 13:39:23 +0000
@@ -1,1 +1,1 @@
-0.9.25
+0.9.26