lazr.restful

Merge lp:~leonardr/lazr.restful/example-service-has-web-link into lp:lazr.restful

  1. example-service-has-web-link
  2. Merge into trunk
Proposed by Leonard Richardson
Status: Merged
Merged at revision: 170
Proposed branch: lp:~leonardr/lazr.restful/example-service-has-web-link
Merge into: lp:lazr.restful
To merge this branch: bzr merge lp:~leonardr/lazr.restful/example-service-has-web-link
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) code Approve
Review via email: mp+48313@code.launchpad.net

Description of the change

This branch registers adapters within the example web service to give it the 'web_link' feature. This feature is already well-tested in unit tests, but adding it to the example web service is the best way to test how well it works with lazr.restfulclient.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Discussed on IRC (and thanks for being patient with me—this stuff is still largely black magic to me).

Points we covered:

 * We looked for something more specific than Interface for the IAbsoluteURL adapter, but found nothing.

We considered ILocation but you found that it might be misleading. We didn't think it worth the trouble to invent a new interface for this.

 * SimulatedWebsiteRequest is probably clearer than WebBrowserOriginatingRequest.

I had to struggle to come up with criticisms. Keep 'em coming.

Jeroen

review: Approve (code)
lp:~leonardr/lazr.restful/example-service-has-web-link updated
171. By Leonard Richardson

Clarified what's going on with the simulated website request.

Subscribers

People subscribed via source and target branches