Merge lp:~leonardr/lazr.restful/561521 into lp:lazr.restful
Status: | Merged |
---|---|
Approved by: | Edwin Grubbs |
Approved revision: | 130 |
Merged at revision: | not available |
Proposed branch: | lp:~leonardr/lazr.restful/561521 |
Merge into: | lp:lazr.restful |
Diff against target: |
436 lines (+123/-47) 5 files modified
src/lazr/restful/NEWS.txt (+8/-3) src/lazr/restful/_resource.py (+46/-13) src/lazr/restful/docs/webservice-declarations.txt (+6/-13) src/lazr/restful/docs/webservice.txt (+62/-17) src/lazr/restful/version.txt (+1/-1) |
To merge this branch: | bzr merge lp:~leonardr/lazr.restful/561521 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | Approve | ||
Review via email: mp+23404@code.launchpad.net |
Description of the change
This branch fixes bug 561521, in which a Launchpad test was found to fail on some Lucid installs because modifications dictated by PATCH requests happened in a nondeterministic order. This branch enforces a 1) deterministic order that's 2) less likely to cause problems.
The new order is less likely to cause problems because all of an entry's fields that are handled by mutator methods are saved until last. For testability purposes, I defined a helper function get_entry_
I also did some drive-by cleanup of test headings.
I have one slight misgiving about the get_entry_
You could argue that I'm really looking for an instance of PropertyWithMut
Oh, I should mention that in addition to testing the unit tests, I tested this branch in conjunction with Launchpad to make sure it made the test failure go away. (The test that failed was webservice/ xx-distribution .txt)