Merge lp:~leonardr/launchpadlib/use-beta-service into lp:launchpadlib

Proposed by Leonard Richardson on 2010-02-17
Status: Merged
Approved by: Michael Hudson-Doyle on 2010-02-17
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~leonardr/launchpadlib/use-beta-service
Merge into: lp:launchpadlib
Diff against target: 25 lines (+2/-2)
2 files modified
src/launchpadlib/launchpad.py (+1/-1)
src/launchpadlib/tests/test_launchpad.py (+1/-1)
To merge this branch: bzr merge lp:~leonardr/launchpadlib/use-beta-service
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle (community) 2010-02-17 Approve on 2010-02-17
Review via email: mp+19453@code.launchpad.net
To post a comment you must log in.
Leonard Richardson (leonardr) wrote :

This branch changes the default version of Launchpad's web service used by launchpadlib. Using the 'devel' version everywhere doesn't make sense--most developers want a stable API, and the 'devel' version doesn't even exist on Launchpad yet. This branch pegs everything to 'beta', recreating the behavior of launchpadlib before it was made capable of talking to multiple versions. In general, the web service version used by launchpadlib by default will be "the latest stable version". Right now, that's beta.

Michael Hudson-Doyle (mwhudson) wrote :

OK yeah, that's pretty simple :-)

review: Approve
84. By Leonard Richardson on 2010-02-17

Change the test to reflect the fact that the default version is 'beta'.

Michael Hudson-Doyle (mwhudson) wrote :

Still looks fine...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/launchpadlib/launchpad.py'
2--- src/launchpadlib/launchpad.py 2010-02-15 16:34:26 +0000
3+++ src/launchpadlib/launchpad.py 2010-02-17 00:17:19 +0000
4@@ -76,7 +76,7 @@
5 :type credentials: `Credentials`
6 """
7
8- DEFAULT_VERSION = 'devel'
9+ DEFAULT_VERSION = 'beta'
10
11 RESOURCE_TYPE_CLASSES = {
12 'bugs': BugSet,
13
14=== modified file 'src/launchpadlib/tests/test_launchpad.py'
15--- src/launchpadlib/tests/test_launchpad.py 2010-02-15 16:34:26 +0000
16+++ src/launchpadlib/tests/test_launchpad.py 2010-02-17 00:17:19 +0000
17@@ -165,7 +165,7 @@
18 timeout=timeout,
19 proxy_info=proxy_info,
20 cache=os.path.join(self.temp_dir, 'api.example.com', 'cache'),
21- version='devel')
22+ version='beta')
23 self.assertEqual(launchpad.passed_in_kwargs, expected_arguments)
24
25 def test_anonymous_login(self):

Subscribers

People subscribed via source and target branches