Merge lp:~leonardr/launchpad/web-link into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12324 | ||||
Proposed branch: | lp:~leonardr/launchpad/web-link | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
981 lines (+108/-61) 37 files modified
lib/canonical/launchpad/browser/librarian.py (+1/-3) lib/canonical/launchpad/doc/canonical_url_examples.txt (+1/-1) lib/canonical/launchpad/webapp/configure.zcml (+1/-1) lib/canonical/launchpad/webapp/interfaces.py (+0/-8) lib/lp/app/doc/tales.txt (+2/-2) lib/lp/blueprints/tests/test_webservice.py (+2/-1) lib/lp/bugs/browser/configure.zcml (+6/-3) lib/lp/bugs/browser/tests/buglinktarget-views.txt (+2/-2) lib/lp/bugs/interfaces/bugnomination.py (+1/-1) lib/lp/bugs/interfaces/bugsubscription.py (+1/-1) lib/lp/bugs/stories/webservice/xx-bug-tracker.txt (+2/-0) lib/lp/bugs/stories/webservice/xx-bug.txt (+17/-2) lib/lp/code/interfaces/diff.py (+1/-1) lib/lp/code/stories/webservice/xx-branch.txt (+1/-1) lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+5/-1) lib/lp/code/stories/webservice/xx-branchsubscription.txt (+2/-0) lib/lp/hardwaredb/interfaces/hwdb.py (+9/-9) lib/lp/registry/interfaces/productrelease.py (+1/-1) lib/lp/registry/interfaces/structuralsubscription.py (+1/-1) lib/lp/registry/interfaces/wikiname.py (+1/-1) lib/lp/registry/stories/webservice/xx-distribution-mirror.txt (+4/-0) lib/lp/registry/stories/webservice/xx-distribution-source-package.txt (+2/-1) lib/lp/registry/stories/webservice/xx-distribution.txt (+2/-0) lib/lp/registry/stories/webservice/xx-distroseries.txt (+1/-1) lib/lp/registry/stories/webservice/xx-person.txt (+5/-1) lib/lp/registry/stories/webservice/xx-project-registry.txt (+14/-4) lib/lp/services/worlddata/interfaces/country.py (+2/-1) lib/lp/soyuz/interfaces/archivedependency.py (+1/-1) lib/lp/soyuz/interfaces/archivepermission.py (+1/-1) lib/lp/soyuz/interfaces/packageset.py (+3/-3) lib/lp/soyuz/interfaces/publishing.py (+2/-2) lib/lp/soyuz/interfaces/queue.py (+1/-1) lib/lp/soyuz/stories/webservice/xx-archive.txt (+5/-0) lib/lp/soyuz/stories/webservice/xx-builds.txt (+3/-1) lib/lp/soyuz/stories/webservice/xx-distroarchseries.txt (+1/-1) lib/lp/translations/stories/webservice/xx-potemplate.txt (+1/-0) versions.cfg (+3/-3) |
||||
To merge this branch: | bzr merge lp:~leonardr/launchpad/web-link | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email:
|
Commit message
[r=thumper][bug=316694] Add a web_link property to the JSON representation of all web service entries that correspond to some page on the Launchpad website.
Description of the change
Many of the objects published over the Launchpad web service correspond to some page on the Launchpad website. To take a simple example, the entry at https:/
With this branch in place, the JSON representation of https:/
This branch removes IWebBrowserOrig
However, not *every* object published over the Launchpad web service corresponds to some page on the website. I was able to find the following exceptions: bug nominations, bug subscriptions, preview diffs, product release files, structural subscriptions, wiki names, countries, archive dependencies, archive permissions, packagesets, publishing histories, and package uploads, along with everything related to the HWDB. I annotated the interfaces of all these exceptions by adding "publish_
It's possible that I missed more exceptions. The worst that will happen is that we'll be publishing web_links that don't work, and when someone notices we'll be able to add another exception.
I changed the <browser:url> stanzas in three places in lib/lp/
The bulk of this diff is changes to tests. These changes may look fairly pointless--I'm just adding 'web_link' to a lot of representations
Basically, I think the changes to the tests are important. I *don't* think it's particularly important to test the specific values for web_link. We could improve readibility with very little loss of coverage by replacing all these lines:
web_link: 'http://
with this:
web_link: '...'
IOW just verifying that there *is* a web link, since in Launchpad it's always similar to the self_link,
I thought that I would catch a lot of 'incorrect rootsite' type errors by printing out the web_link in some detail, but as I mentioned, I only caught two: ICVE and IBugSubscription.
Hopefully this branch isn't too confusing. There's a lot of details but conceptually it's pretty simple, I think.
Looks good to me. Thanks for getting this working.