Merge lp:~leonardr/launchpad/reword-desktop-integration into lp:launchpad/db-devel
Status: | Superseded |
---|---|
Proposed branch: | lp:~leonardr/launchpad/reword-desktop-integration |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
309 lines (+83/-62) 6 files modified
lib/canonical/launchpad/database/oauth.py (+23/-11) lib/canonical/launchpad/pagetests/oauth/authorize-token.txt (+8/-10) lib/canonical/launchpad/pagetests/oauth/managing-tokens.txt (+47/-32) lib/canonical/launchpad/templates/oauth-authorize.pt (+1/-1) lib/canonical/launchpad/templates/token-authorized.pt (+3/-7) lib/canonical/launchpad/webapp/interfaces.py (+1/-1) |
To merge this branch: | bzr merge lp:~leonardr/launchpad/reword-desktop-integration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Māris Fogels (community) | Approve | ||
Review via email: mp+39892@code.launchpad.net |
This proposal has been superseded by a proposal from 2010-11-03.
Description of the change
This branch makes two changes to improve the user experience for desktop-wide integration.
1. Instead of referring to the client computer as "The [system type]" it now refers to the client as "The [system type] computer". The original plan was that the client would know whether it was running on a desktop, a server or a phone, and send the appropriate information in the system type, eg. "Ubuntu desktop", "Android phone". But this turns out not to be possible right now. The best we can do ATM is determine the OS, eg. "Ubuntu" or "Darwin". This branch changes the templates so that you see "The Ubuntu computer" instead of "The Ubuntu".
2. On your list of authorized clients, a desktop integration token showed up as "Authorized to desktop integration", which doesn't make grammatical sense. I changed things so that it shows up as "Authorized to integrate an entire computer". I cleaned up the test for this a little bit, replacing some custom object-creation code with corresponding factory code, but I didn't go all the way because I just want to get this out the door and be done with it.
I don't know whether this needs a UI review--I'm changing code and templates, but the effect is just to correct obvious grammatical problems.
Hi Leonard,
This looks good, r=mars.