Merge lp:~leonardr/launchpad/launchpadlib-pagetests-take-2 into lp:launchpad/db-devel
| Status: | Merged |
|---|---|
| Merged at revision: | not available |
| Proposed branch: | lp:~leonardr/launchpad/launchpadlib-pagetests-take-2 |
| Merge into: | lp:launchpad/db-devel |
| Diff against target: |
615 lines (+340/-92) 12 files modified
Makefile (+0/-4) lib/canonical/buildd/debian/control (+1/-1) lib/canonical/launchpad/apidoc/wadl-testrunner-devel.xml (+0/-10) lib/canonical/launchpad/browser/oauth.py (+25/-13) lib/canonical/launchpad/doc/oauth.txt (+54/-0) lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt (+50/-0) lib/canonical/launchpad/pagetests/webservice/xx-wadl.txt (+68/-59) lib/canonical/launchpad/systemhomes.py (+9/-4) lib/canonical/launchpad/testing/pages.py (+5/-1) lib/canonical/testing/layers.py (+7/-0) lib/lp/testing/__init__.py (+2/-0) lib/lp/testing/_webservice.py (+119/-0) |
| To merge this branch: | bzr merge lp:~leonardr/launchpad/launchpadlib-pagetests-take-2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Guilherme Salgado (community) | code | Approve on 2010-03-31 | |
| Michael Hudson-Doyle | 2010-03-30 | Approve on 2010-03-30 | |
|
Review via email:
|
|||
Description of the Change
This is the second version of my branch to make it possible to use launchpadlib in pagetests. The previous branch was landed and then removed because it caused mysterious, catastrophic test failures (though not on my dev machine, on ec2, or on buildout).
The previous branch put a 'launchpad' object in the globally accessible globs. This branch instead makes available a 'launchpadlib_for' helper function that will create a Launchpad object for any user, creating the underlying OAuth credential if necessary. Most of the work happens in two more granular helper methods, launchpadlib_
I refactored the code that turns a string into an OAuth context object into a helper function, so that oauth_access_
Everything else in this branch (eg. the change to the WADL code) is exactly the same as in the previous launchpadlib pagetest branch.
| Leonard Richardson (leonardr) wrote : | # |
| Michael Hudson-Doyle (mwhudson) wrote : | # |
I don't understand the changes to xx-wadl.txt but they've already been reviewed once already, right?
The rest looks fine.
| Leonard Richardson (leonardr) wrote : | # |
ec2 test turned up some test failures. Two of them were trivial to fix; one was quite difficult and revealed that Launchpad doesn't really support a feature we thought we'd implemented. I filed bug 552732 to cover that and left the test in place but commented out. Incremental diff:
| Guilherme Salgado (salgado) wrote : | # |
Per Leonard's request I've reviewed http://

wgrant informs me that this branch _did_ cause test failures everywhere, but the failures were so bad the test suite didn't register them as failures.