Merge lp:~leonardr/launchpad/launchpadlib-integration into lp:launchpad
Proposed by
Leonard Richardson
Status: | Merged |
---|---|
Merged at revision: | 12167 |
Proposed branch: | lp:~leonardr/launchpad/launchpadlib-integration |
Merge into: | lp:launchpad |
Diff against target: |
84 lines (+13/-7) 4 files modified
lib/canonical/launchpad/pagetests/webservice/launchpadlib.txt (+6/-3) lib/lp/testing/_webservice.py (+2/-2) setup.py (+2/-0) versions.cfg (+3/-2) |
To merge this branch: | bzr merge lp:~leonardr/launchpad/launchpadlib-integration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Māris Fogels (community) | Approve | ||
Review via email: mp+45174@code.launchpad.net |
Description of the change
This branch makes some minor changes to launchpadlib that I made while integrating my branch https:/
* Bumped the version number.
* Removed a doctest of login(), since the method is deprecated (and it now has a unit test).
* Made the TestableLaunchpad class provide default values for credential_store and authorization_
* Changed the KnownTokens convenience class to pass in a Credentials object into the TestableLaunchpad constructor, rather than using the now-deprecated login() method.
To post a comment you must log in.
Sorry, this is the wrong branch for that MP. Here's the real MP.
This branch makes some minor changes to launchpadlib that I made while integrating my branch https:/ /code.launchpad .net/~leonardr/ launchpadlib/ launchpad- integration into Launchpad.
* Require new versions of launchpadlib and lazr.restfulclient
* Require the 'keyring' module, a new dependency of launchpadlib
* Many tests invoke the Launchpad constructor, which now takes two new arguments (a token authorization engine and a credential store). These tests don't need either, which is why they're invoking the constructor instead of using login_with(). I changed the tests to pass in None for those two arguments.