Merge lp:~leonardr/launchpad/get-field-uri into lp:launchpad
Proposed by
Leonard Richardson
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | 9493 |
Merge reported by: | Leonard Richardson |
Merged at revision: | not available |
Proposed branch: | lp:~leonardr/launchpad/get-field-uri |
Merge into: | lp:launchpad |
Diff against target: |
71 lines 2 files modified
lib/canonical/launchpad/pagetests/packaging/xx-sourcepackage-packaging.txt (+14/-0) lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt (+17/-0) |
To merge this branch: | bzr merge lp:~leonardr/launchpad/get-field-uri |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Hummer (community) | Approve | ||
Review via email: mp+12344@code.launchpad.net |
To post a comment you must log in.
This branch adds a new Javascript utility function, get_field_uri(). This function lets you get the URI to a field resource, given an entry resource and a field name.
In addition to unit tests of the new function, this branch adds two tests that make sure patch() works on a field resource.
This branch also gets rid of the client_ parse_xml_ entry method, which is not used within Launchpad and which was a bad idea in the first place.
You'll get one Javascript failure when running the Windmill tests, but that's a failure currently in trunk; it's not introduced by this branch.