soyuz: fix up removal of stale i18n/Index upon removal
During qastaging testing it was discovered that i18n/Index publishing
correctly honors publish_i18n_index setting for freshly created suites
in an archive. But existing archives incorrectly left stale i18n/Index
on disk (whilst scheduling byhash symlink removal).
QA Testing:
* create a new archive on qastaging
* publish it once
* verify i18n/Index is published with byhash link to it
* toggle publish_i18n_index off
* publish it again
* verify i18n/Index is gone straight away
* verify deathrow 24h later removed byhash link to it as well
Fixes: 5f90943b2f ("soyuz: Add toggle to turn off I18n/Index publishing")
soyuz: fix up removal of stale i18n/Index upon removal
During qastaging testing it was discovered that i18n/Index publishing
correctly honors publish_i18n_index setting for freshly created suites
in an archive. But existing archives incorrectly left stale i18n/Index
on disk (whilst scheduling byhash symlink removal).
QA Testing:
* create a new archive on qastaging
* publish it once
* verify i18n/Index is published with byhash link to it
* toggle publish_i18n_index off
* publish it again
* verify i18n/Index is gone straight away
* verify deathrow 24h later removed byhash link to it as well
Improve unit test to correctly setup status quo publication, and
assert removal of the i18n/Index file upon change of the distroseries
publication setting.
Fixes: 5f90943b2f ("soyuz: Add toggle to turn off I18n/Index publishing")
Signed-off-by: Dimitri John Ledkov <email address hidden>