Merge lp:~leeturner/quam-plures/system_app_homepage_fix into lp:quam-plures

Proposed by Lee Turner
Status: Merged
Merged at revision: 7613
Proposed branch: lp:~leeturner/quam-plures/system_app_homepage_fix
Merge into: lp:quam-plures
Diff against target: 14 lines (+2/-1)
1 file modified
qp_inc/tools/views/_system_list.view.php (+2/-1)
To merge this branch: bzr merge lp:~leeturner/quam-plures/system_app_homepage_fix
Reviewer Review Type Date Requested Status
Tilman Blumenbach (community) Approve
EdB Approve
Review via email: mp+72844@code.launchpad.net

Description of the change

See this thread for details:

http://forums.quamplures.net/viewtopic.php?f=16&t=653

Nothing major here. This branch just fixes the missing $app_homepage variable in the System screen which currently has the error:

PHP Notice: Undefined variable: app_homepage in /Applications/MAMP/htdocs/system_app_homepage_fix/qp_inc/tools/views/_system_list.view.php on line 103

To post a comment you must log in.
Revision history for this message
EdB (edb) wrote :

I can't believe I never noticed that error until I testing 3 branches at the same time to see what this is fixing.

Approved, appropriate delay, merge imminent.

review: Approve
Revision history for this message
Tilman Blumenbach (tblue) wrote :

Just for the record, looks good.

Revision history for this message
Tilman Blumenbach (tblue) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qp_inc/tools/views/_system_list.view.php'
2--- qp_inc/tools/views/_system_list.view.php 2010-12-31 12:12:03 +0000
3+++ qp_inc/tools/views/_system_list.view.php 2011-08-25 09:35:39 +0000
4@@ -33,8 +33,9 @@
5 if( !defined('QP_MAIN_INIT') ) die( 'Please, do not access this page directly.' );
6
7 global $app_name;
8+global $app_version;
9 global $app_date;
10-global $app_version;
11+global $app_homepage;
12 global $localtimenow;
13 global $media_path;
14 global $basepath;

Subscribers

People subscribed via source and target branches