Merge lp:~leeturner/quam-plures/stub_file_name into lp:quam-plures

Proposed by Lee Turner
Status: Merged
Merged at revision: 7642
Proposed branch: lp:~leeturner/quam-plures/stub_file_name
Merge into: lp:quam-plures
Diff against target: 25 lines (+2/-2)
2 files modified
qp_inc/collections/collections.ctrl.php (+1/-1)
qp_inc/dashboard/dashboard.ctrl.php (+1/-1)
To merge this branch: bzr merge lp:~leeturner/quam-plures/stub_file_name
Reviewer Review Type Date Requested Status
EdB Approve
Review via email: mp+116108@code.launchpad.net

Description of the change

http://forums.quamplures.net/viewtopic.php?f=11&t=1160

Changes the filename of the stub file that is created from BlogX.php to urlname.php format.

To post a comment you must log in.
Revision history for this message
EdB (edb) wrote :

Approving, but see http://forums.quamplures.net/viewtopic.php?p=7906#p7906 for an unrelated bug that is fixable in here ... or in another branch

review: Approve
7643. By Lee Turner <email address hidden>

Fixed link to create new blog in dashboard

Revision history for this message
Lee Turner (leeturner) wrote :

Please update and text again as I have now fixed the create blog link.

Revision history for this message
EdB (edb) wrote :

will re-test later - gotta go make some money :)

Revision history for this message
Lee Turner (leeturner) wrote :

Cool

Hope the work life is going well for you !

L

Revision history for this message
EdB (edb) wrote :

still approved :)

review: Approve
Revision history for this message
EdB (edb) wrote :

If no other comments happen soon I'll merge this tomorrow

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qp_inc/collections/collections.ctrl.php'
2--- qp_inc/collections/collections.ctrl.php 2010-12-31 12:12:03 +0000
3+++ qp_inc/collections/collections.ctrl.php 2012-07-21 16:11:20 +0000
4@@ -133,7 +133,7 @@
5 else
6 { // we are happy :)
7 $file_imploded = implode( '', $file_loaded );
8- $stub_filename = 'blog'.$edited_Blog->ID.'.php';
9+ $stub_filename = $edited_Blog->urlname.'.php';
10 $new_file = $basepath.$stub_filename;
11 $f = @fopen( $new_file , 'w' );
12 if( $f == false )
13
14=== modified file 'qp_inc/dashboard/dashboard.ctrl.php'
15--- qp_inc/dashboard/dashboard.ctrl.php 2011-11-21 17:17:22 +0000
16+++ qp_inc/dashboard/dashboard.ctrl.php 2012-07-21 16:11:20 +0000
17@@ -366,7 +366,7 @@
18 }
19 if( $current_User->check_perm( 'blogs', 'create' ) )
20 {
21- echo '<li><a href="'.$dispatcher.'?ctrl=blogs&amp;action=new">'.T_('Create new blog').' &raquo;</a></li>';
22+ echo '<li><a href="'.$dispatcher.'?ctrl=collections&amp;action=new">'.T_('Create new blog').' &raquo;</a></li>';
23 }
24 echo '<li><a href="'.$dispatcher.'?ctrl=templates">'.T_('Install a template').' &raquo;</a></li>';
25 echo '<li><a href="'.$dispatcher.'?ctrl=plugins">'.T_('Install a plugin').' &raquo;</a></li>';

Subscribers

People subscribed via source and target branches