Merge lp:~learts92/sale-wkfl/7.0-add-sale-order-authorized-users into lp:~sale-core-editors/sale-wkfl/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~learts92/sale-wkfl/7.0-add-sale-order-authorized-users |
Merge into: | lp:~sale-core-editors/sale-wkfl/7.0 |
Diff against target: |
140 lines (+114/-0) 5 files modified
sale_order_authorized_users/__init__.py (+2/-0) sale_order_authorized_users/__openerp__.py (+47/-0) sale_order_authorized_users/sale.py (+34/-0) sale_order_authorized_users/sale_view.xml (+18/-0) sale_order_authorized_users/security/hide_sale_orders_security.xml (+13/-0) |
To merge this branch: | bzr merge lp:~learts92/sale-wkfl/7.0-add-sale-order-authorized-users |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | Needs Resubmitting | ||
Review via email: mp+227325@code.launchpad.net |
Description of the change
Let Admin (or any user in the base.group_
which users will be able to access and see it. Any other user won't be able
to see it.
If no users are set, the sale order has normal permissions.
The field to set allowed users will be visibile only to admin, which makes it
possible to make the users unaware of this feature.
Things that could be improved:
- Tests?
- create security rule also for sale_order_line if it's not automatic.
It's not 100% secure atm, but probably good enough for normal users.
Unmerged revisions
- 50. By Leonardo Donelli
-
Fix import and copyright notice.
- 49. By Leonardo Donelli
-
New module sale_order_
authorized_ users Let Admin (or any user in the base.group_
erp_manager) choose, for each sale order,
which users will be able to access and see it. Any other user won't be able
to see it.
If no users are set, the sale order has normal permissions.
The field to set allowed users will be visibile only to admin, which makes it
possible to make the users unaware of this feature and that some orders are
hidden from them.
This project is now hosted on https:/ /github. com/OCA/ sale-workflow. Please move your proposal there. This guide may help you https:/ /github. com/OCA/ maintainers- tools/wiki/ How-to- move-a- Merge-Proposal- to-GitHub