Merge lp:~leannogasawara/apport/ubuntu-bugpatterns into lp:~ubuntu-bugcontrol/apport/ubuntu-bugpatterns

[Leann Ogasawara]

[Leann Ogasawara (leannogasawara)]

Even though I'm a member of ubuntu-bugcontrol I just wanted to get a quick review of an ubuntu-bugpattern that I wrote before I push. The test-local script passes only after applying the patch mentioned in bug 382589. Thanks.

[Brian Murray (brian-murray)]

Testing the pattern on some of the duplicates it doesn't seem to match that many of them. Are there any changes we could make to get the pattern to cover more of the duplicates?

wonderwoman:[...patterns/ubuntu-bugpatterns] for i in 380582 376926
376390 376029 375876 372475; do ./test-local $i; done
LP: #380582: No match
LP: #376926: Matched bug pattern: https://launchpad.net/bugs/269539
LP: #376390: No match
LP: #376029: Matched bug pattern: https://launchpad.net/bugs/269539
LP: #375876: No match
LP: #372475: No match

review: Needs Information

[Brian Murray (brian-murray)]

> Testing the pattern on some of the duplicates it doesn't seem to match that
> many of them. Are there any changes we could make to get the pattern to cover
> more of the duplicates?

Looking at some of the ones that failed the attachment is VarLogDistUpgradeYYYYMMDD.gz which isn't in "APPORT_FILES" in launchpad.py additionally I'm not certain how that would be added since the attachment name is dynamic. So upon reflection I think this might be as good as it can get for now.

[Leann Ogasawara (leannogasawara)]

> > Testing the pattern on some of the duplicates it doesn't seem to match that
> > many of them. Are there any changes we could make to get the pattern to
> cover
> > more of the duplicates?
>
> Looking at some of the ones that failed the attachment is
> VarLogDistUpgradeYYYYMMDD.gz which isn't in "APPORT_FILES" in launchpad.py
> additionally I'm not certain how that would be added since the attachment name
> is dynamic. So upon reflection I think this might be as good as it can get
> for now.

Adding a note for myself that bug 383655 should resolve the VarLogDistUpgrade* attachment issue. I'll fix up my bugpattern and resubmit.

[Leann Ogasawara (leannogasawara)]

> > > Testing the pattern on some of the duplicates it doesn't seem to match
> that
> > > many of them. Are there any changes we could make to get the pattern to
> > cover
> > > more of the duplicates?
> >
> > Looking at some of the ones that failed the attachment is
> > VarLogDistUpgradeYYYYMMDD.gz which isn't in "APPORT_FILES" in launchpad.py
> > additionally I'm not certain how that would be added since the attachment
> name
> > is dynamic. So upon reflection I think this might be as good as it can get
> > for now.
>
> Adding a note for myself that bug 383655 should resolve the VarLogDistUpgrade*
> attachment issue. I'll fix up my bugpattern and resubmit.

Ran into a bug with the test-local script when testing the bugpattern that checks VarLogDistUpgrade*:

https://bugs.edge.launchpad.net/ubuntu/+source/apport/+bug/397150

I've gone ahead and pushed the original bug pattern which checked DpkgTerminalLog and will push this second half that checks VarLogDistUpgrade once I can confirm it's working properly via the test-local script.

=== modified file 'linux.xml'
--- linux.xml	2009-05-28 16:33:22 +0000
+++ linux.xml	2009-06-01 23:21:06 +0000
@@ -8,4 +8,7 @@
         <re key="ProcCmdLine">loop=/hostname/disks/home/username.disk</re>
 	<re key="ErrorMessage">^unable to make backup link of.*before installing new version: Operation not permitted$</re>
     </pattern>
+    <pattern url="https://launchpad.net/bugs/269539">
+        <re key="DpkgTerminalLog">The file `/var/run/grub/menu.lst.ucf-new' has a record of the failed merge of the configuration file.</re>
+    </pattern>
 </patterns>