Merge lp:~le-chi-thu/lava-test/override-test-options into lp:lava-test/0.0

Proposed by Le Chi Thu
Status: Merged
Merged at revision: 104
Proposed branch: lp:~le-chi-thu/lava-test/override-test-options
Merge into: lp:lava-test/0.0
Diff against target: 37 lines (+6/-7)
1 file modified
lava_test/test_definitions/tiobench.py (+6/-7)
To merge this branch: bzr merge lp:~le-chi-thu/lava-test/override-test-options
Reviewer Review Type Date Requested Status
Paul Larson (community) Approve
Review via email: mp+80002@code.launchpad.net

Description of the change

Now I tested it and here is the result.
http://validation.linaro.org/lava-server/dashboard/streams/anonymous/lechithu/bundles/df4600905efb319b1a140cf8c31517914fa01c43/

BTW the one you merged to trunk has a bug in tiobench.py which I now fixed.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Thanks, I'll update it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_test/test_definitions/tiobench.py'
2--- lava_test/test_definitions/tiobench.py 2011-10-20 12:12:15 +0000
3+++ lava_test/test_definitions/tiobench.py 2011-10-20 21:13:23 +0000
4@@ -39,7 +39,7 @@
5
6
7 class TIObenchTestParser(TestParser):
8- def parse(self):
9+ def parse(self, artifacts):
10 # Pattern to match the test case name
11 pattern1="(?P<test_id>^(Sequential|Random) (Writes|Reads))"
12 # Pattern to match the parameter details and measurement
13@@ -50,7 +50,7 @@
14 pat2 = re.compile(pattern2)
15 tc_id = None
16 with open(filename) as fd:
17- for line in fd:
18+ for lineno, line in enumerate(fd, 1):
19 match1 = pat1.match(line)
20 match2 = pat2.search(line)
21 if match1:
22@@ -62,11 +62,10 @@
23 results['test_case_id'] = (
24 '%s_%sMBfilesize_%sbytesblksize') % (
25 tc_id, filesize, blks_size)
26- self.results['test_results'].append(results)
27-
28- if self.appendall:
29- self.appendtoall(self.appendall)
30- self.fixmeasurements()
31+ results["log_filename"] = "testoutput.log"
32+ results["log_lineno"] = lineno
33+ self.results['test_results'].append(
34+ self.analyze_test_result(results))
35
36 tiobench_inst = TestInstaller(INSTALLSTEPS, url=URL,
37 md5=MD5)

Subscribers

People subscribed via source and target branches