Merge lp:~le-chi-thu/lava-test/add-reset-command into lp:lava-test/0.0

[Le Chi Thu]

When new test job run with out deploying a new test image, there are old test result, installed tests and cached out-of-tree tests in the test image file system you want to removed. This command will be used to remove them.

[Zygmunt Krynicki (zyga)]

30 +
31 + def invoke(self):
32 + print "Delete " + self._config.configdir
33 + os.system("rm -rf " + self._config.configdir)
34 + print "Delete " + self._config.installdir
35 + os.system("rm -rf " + self._config.installdir)
36 + print "Delete " + self._config.resultsdir
37 + os.system("rm -rf " + self._config.resultsdir)
38 + cache = Cache.get_instance()
39 + print "Delete " + cache.cache_dir
40 + os.system("rm -rf " + cache.cache_dir)

Please use shutil.rmtree(), os.system() is wrong and error prone on many levels.
Otherwise this is okay

review: Needs Fixing

[Le Chi Thu (le-chi-thu)]

Fixed

review: Needs Resubmitting

[lp:~le-chi-thu/lava-test/add-reset-command]

123. By Le Chi Thu <email address hidden> <email address hidden> on 2012-03-06

Replaced os.system with shutil.rmtree

[Zygmunt Krynicki (zyga)]

+1

review: Approve

=== modified file 'lava_test/commands.py'
--- lava_test/commands.py	2012-03-06 12:59:07 +0000
+++ lava_test/commands.py	2012-03-06 14:05:20 +0000
@@ -1,4 +1,4 @@
-# Copyright (c) 2010, 2011 Linaro
+# Copyright (c) 2010, 2011, 2012 Linaro
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -15,6 +15,7 @@
 import logging
 
 import os
+import shutil
 import subprocess
 
 from lava_tool.interface import Command as LavaCommand
@@ -27,7 +28,7 @@
 from lava_test.core.artifacts import TestArtifacts
 from lava_test.core.config import get_config
 from lava_test.core.loader import TestLoader
-
+from lava_test.utils import Cache
 
 class Command(LavaCommand, ITestInstallerObserver, ITestRunnerObserver):
 
@@ -411,3 +412,21 @@
             raise LavaCommandError("Unable to unregister test: %s" % exc)
         except KeyError:
             raise LavaCommandError("There is no test_url")
+
+
+class reset(Command):
+    """
+    Reset the lava-test environment by removing
+    cached items, all registerered simple declactive tests and configuration files
+    """
+
+    def invoke(self):
+        print "Delete " + self._config.configdir
+        shutil.rmtree(self._config.configdir, ignore_errors=True)
+        print "Delete " + self._config.installdir
+        shutil.rmtree(self._config.installdir, ignore_errors=True)
+        print "Delete " + self._config.resultsdir
+        shutil.rmtree(self._config.resultsdir, ignore_errors=True)
+        cache = Cache.get_instance()
+        print "Delete " + cache.cache_dir
+        shutil.rmtree(cache.cache_dir, ignore_errors=True)
\ No newline at end of file

=== modified file 'setup.py'
--- setup.py	2012-02-06 15:48:33 +0000
+++ setup.py	2012-03-06 14:05:20 +0000
@@ -1,6 +1,6 @@
 #!/usr/bin/env python
 
-# Copyright (c) 2010, 2011 Linaro
+# Copyright (c) 2010, 2011, 2012 Linaro
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -43,6 +43,7 @@
     show=lava_test.commands:show
     register_test=lava_test.commands:register_test
     unregister_test=lava_test.commands:unregister_test
+    reset=lava_test.commands:reset
     """,
     classifiers=[
         "Development Status :: 3 - Alpha",