Code review comment for lp:~le-chi-thu/lava-android-test/add-sdcard-tests

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Thanks for this addition, but the bad news is that the lava deployed android image does not have the sdcard partition:(

But I'd like to integrated this first, so when we add the sdcard partition for lava deployed android image,
this test can be used immediately. Also we can use the test for data partition now.

And Here I have some comments about this.

203 +internalPath = "/sdcard/"
204 +externalPath = "/data/app/"

In android /sdcard is normally call external, so it's better to change the two variable names.
And about the "/data/app/" path, if not have special meanings I'd like to use "/data/local" instead.

311 + print "sdcard_df_check=fail"

From the above, it seems that just used to check the mount of sdcard.
But actually we check the sdcard and data two.

And about the filetransfertest test, only one transfer is enough for the test?
Normally, only one time will not have any problem IMO.

« Back to merge proposal