Ubuntu

Merge lp:~le-businessman/ubuntu/raring/libcommoncpp2/fix-for-1176058 into lp:ubuntu/raring/libcommoncpp2

Proposed by Tristan Matthews on 2013-05-29
Status: Work in progress
Proposed branch: lp:~le-businessman/ubuntu/raring/libcommoncpp2/fix-for-1176058
Merge into: lp:ubuntu/raring/libcommoncpp2
Diff against target: 44 lines (+24/-0) 3 files modified
To merge this branch: bzr merge lp:~le-businessman/ubuntu/raring/libcommoncpp2/fix-for-1176058
Reviewer Review Type Date Requested Status
James Page Needs Fixing on 2013-06-03
Ubuntu branches 2013-05-29 Pending
Review via email: mp+166377@code.launchpad.net

Description of the Change

This fixes the invalid memset in inaddr.cpp which causes a buffer overlflow on 64-bit systems.

https://bugs.launchpad.net/ubuntu/+source/libcommoncpp2/+bug/1176058

To post a comment you must log in.
13. By Tristan Matthews on 2013-05-29

Fix patch description.

James Page (james-page) wrote :

Hi Tristan

Please see Marks comments in the linked bug report on next actions for the security fix.

Thanks.

review: Needs Fixing

Unmerged revisions

13. By Tristan Matthews on 2013-05-29

Fix patch description.

12. By Tristan Matthews on 2013-05-29

* SECURITY UPDATE: Possible buffer overlow on 64-bit
  - debian/patches/inaddr-overflow.patch: fixes overflow
  - LP: #1176058

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2012-06-23 16:02:03 +0000
3+++ debian/changelog 2013-05-29 20:36:26 +0000
4@@ -1,3 +1,11 @@
5+libcommoncpp2 (1.8.1-5ubuntu1) raring-security; urgency=low
6+
7+ * SECURITY UPDATE: Possible buffer overlow on 64-bit
8+ - debian/patches/inaddr-overflow.patch: fixes overflow
9+ - LP: #1176058
10+
11+ -- Tristan Matthews <tristan.matthews@savoirfairelinux.com> Wed, 29 May 2013 15:36:44 -0400
12+
13 libcommoncpp2 (1.8.1-5) unstable; urgency=low
14
15 * wheezey polish
16
17=== added file 'debian/patches/inaddr-overflow.patch'
18--- debian/patches/inaddr-overflow.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/inaddr-overflow.patch 2013-05-29 20:36:26 +0000
20@@ -0,0 +1,15 @@
21+Description: Fix buffer overflow
22+
23+Index: libcommoncpp2/src/inaddr.cpp
24+===================================================================
25+--- libcommoncpp2.orig/src/inaddr.cpp 2013-05-29 15:32:16.136900000 -0400
26++++ libcommoncpp2/src/inaddr.cpp 2013-05-29 15:36:42.695502519 -0400
27+@@ -333,7 +333,7 @@
28+ if(ipaddr)
29+ delete[] ipaddr;
30+ ipaddr = new struct in_addr[1];
31+- memset((void *)&ipaddr[0], 0, sizeof(ipaddr));
32++ memset((void *)&ipaddr[0], 0, sizeof(struct in_addr));
33+ return;
34+ }
35+
36
37=== modified file 'debian/patches/series'
38--- debian/patches/series 2012-06-23 16:02:03 +0000
39+++ debian/patches/series 2013-05-29 20:36:26 +0000
40@@ -3,3 +3,4 @@
41 cleaning_doc.dpatch
42 fix_ciddr_ftbfs.dpatch
43 caddr.diff
44+inaddr-overflow.patch

Subscribers

People subscribed via source and target branches