Merge lp:~ldziedziul/rapid/thumbnails-for-autostart into lp:rapid

Proposed by Łukasz Dziedziul
Status: Needs review
Proposed branch: lp:~ldziedziul/rapid/thumbnails-for-autostart
Merge into: lp:rapid
Diff against target: 21 lines (+2/-2)
1 file modified
raphodo/ (+2/-2)
To merge this branch: bzr merge lp:~ldziedziul/rapid/thumbnails-for-autostart
Reviewer Review Type Date Requested Status
Damon Lynch Disapprove
Review via email:

Commit message

generate thumbnails even if autostart downloading enabled

To post a comment you must log in.
Revision history for this message
Damon Lynch (dlynch3) wrote :

No chance of this being approved. For very important performance reasons, in auto-download thumbnails are generated as the files are downloaded.

review: Disapprove

Unmerged revisions

1116. By Łukasz Dziedziul

generate thumbnails even if autostart downloading enabled

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'raphodo/'
--- raphodo/ 2018-11-05 06:29:25 +0000
+++ raphodo/ 2018-12-23 19:26:43 +0000
@@ -4450,7 +4450,7 @@
4450 else:4450 else:
4451 auto_start = self.autoStart(scan_id)4451 auto_start = self.autoStart(scan_id)
4453 if not auto_start and self.prefs.generate_thumbnails:4453 if self.prefs.generate_thumbnails:
4454 # Generate thumbnails for finished scan4454 # Generate thumbnails for finished scan
4455 model.setSpinnerState(scan_id, DeviceState.idle)4455 model.setSpinnerState(scan_id, DeviceState.idle)
4456 if scan_id in self.thumbnailModel.no_thumbnails_by_scan:4456 if scan_id in self.thumbnailModel.no_thumbnails_by_scan:
@@ -4458,7 +4458,7 @@
4458 self.updateProgressBarState()4458 self.updateProgressBarState()
4459 self.thumbnailModel.generateThumbnails(scan_id, self.devices[scan_id])4459 self.thumbnailModel.generateThumbnails(scan_id, self.devices[scan_id])
4460 self.displayMessageInStatusBar()4460 self.displayMessageInStatusBar()
4461 elif auto_start:4461 if auto_start:
4462 self.displayMessageInStatusBar()4462 self.displayMessageInStatusBar()
4463 if self.jobCodePanel.needToPromptForJobCode():4463 if self.jobCodePanel.needToPromptForJobCode():
4464 self.showMainWindow()4464 self.showMainWindow()


People subscribed via source and target branches