Merge lp:~ldziedziul/rapid/thumbnails-for-autostart into lp:rapid

Proposed by Łukasz Dziedziul
Status: Needs review
Proposed branch: lp:~ldziedziul/rapid/thumbnails-for-autostart
Merge into: lp:rapid
Diff against target: 21 lines (+2/-2)
1 file modified
raphodo/rapid.py (+2/-2)
To merge this branch: bzr merge lp:~ldziedziul/rapid/thumbnails-for-autostart
Reviewer Review Type Date Requested Status
Damon Lynch Disapprove
Review via email: mp+361269@code.launchpad.net

Commit message

generate thumbnails even if autostart downloading enabled

To post a comment you must log in.
Revision history for this message
Damon Lynch (dlynch3) wrote :

No chance of this being approved. For very important performance reasons, in auto-download thumbnails are generated as the files are downloaded.

review: Disapprove

Unmerged revisions

1116. By Łukasz Dziedziul

generate thumbnails even if autostart downloading enabled

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'raphodo/rapid.py'
2--- raphodo/rapid.py 2018-11-05 06:29:25 +0000
3+++ raphodo/rapid.py 2018-12-23 19:26:43 +0000
4@@ -4450,7 +4450,7 @@
5 else:
6 auto_start = self.autoStart(scan_id)
7
8- if not auto_start and self.prefs.generate_thumbnails:
9+ if self.prefs.generate_thumbnails:
10 # Generate thumbnails for finished scan
11 model.setSpinnerState(scan_id, DeviceState.idle)
12 if scan_id in self.thumbnailModel.no_thumbnails_by_scan:
13@@ -4458,7 +4458,7 @@
14 self.updateProgressBarState()
15 self.thumbnailModel.generateThumbnails(scan_id, self.devices[scan_id])
16 self.displayMessageInStatusBar()
17- elif auto_start:
18+ if auto_start:
19 self.displayMessageInStatusBar()
20 if self.jobCodePanel.needToPromptForJobCode():
21 self.showMainWindow()

Subscribers

People subscribed via source and target branches