Rapid Photo Downloader

Merge lp:~ldziedziul/rapid/select-all-images-by-default into lp:rapid

  1. select-all-images-by-default
  2. Merge into zeromq_pyqt
Proposed by Łukasz Dziedziul
Status: Needs review
Proposed branch: lp:~ldziedziul/rapid/select-all-images-by-default
Merge into: lp:rapid
Diff against target: 11 lines (+1/-0)
1 file modified
raphodo/rapid.py (+1/-0)
To merge this branch: bzr merge lp:~ldziedziul/rapid/select-all-images-by-default
Reviewer Review Type Date Requested Status
Damon Lynch Disapprove
Review via email: mp+361268@code.launchpad.net

Commit message

select all images for downloading by default

To post a comment you must log in.
Revision history for this message
Damon Lynch (dlynch3) wrote :

That would select images that have previously been downloaded, which is a bad outcome.

review: Disapprove
Reply

Unmerged revisions

1116. By Łukasz Dziedziul

select all images for downloading by default

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'raphodo/rapid.py'
2--- raphodo/rapid.py 2018-11-05 06:29:25 +0000
3+++ raphodo/rapid.py 2018-12-23 19:22:13 +0000
4@@ -4436,6 +4436,7 @@
5 self.download_tracker.set_file_types_present(scan_id, file_types_present)
6 model = self.mapModel(scan_id)
7 model.updateDeviceScan(scan_id)
8+ self.thumbnailModel.checkAll(True, scan_id=scan_id)
9 destinations_good = self.setDownloadCapabilities()
10
11 self.logState()

Subscribers

People subscribed via source and target branches