Rapid Photo Downloader

Merge lp:~ldziedziul/rapid/fix-thunar-support into lp:rapid

  1. fix-thunar-support
  2. Merge into zeromq_pyqt
Proposed by Łukasz Dziedziul
Status: Needs review
Proposed branch: lp:~ldziedziul/rapid/fix-thunar-support
Merge into: lp:rapid
Diff against target: 12 lines (+1/-1)
1 file modified
raphodo/constants.py (+1/-1)
To merge this branch: bzr merge lp:~ldziedziul/rapid/fix-thunar-support
Reviewer Review Type Date Requested Status
Damon Lynch Disapprove
Review via email: mp+361266@code.launchpad.net

Commit message

open selected file instead of the parent directory in xfce

Description of the change

Thunar can open a single file, no need to open parent directory.

Tested on Xubuntu 18.10, Thunar 1.8.1 (Xfce 4.12)

To post a comment you must log in.
Revision history for this message
Damon Lynch (dlynch3) wrote :

The file is not supposed to be opened. It is supposed to be highlighted (selected) in the file manager. Last I checked, thunar cannot do that. If thunar's behaviour has changed since I checked it, please let me know which version made the change.

review: Disapprove
Reply
Revision history for this message
Łukasz Dziedziul (ldziedziul) wrote :

Ah, I see. By from user perspective it's more useful to open file then only select it in the file browser, don't you think?

Alternatively, I could prepare a new merge request add new menu item: "Preview" next to "Open in File Browser..."

I usually want to preview the file before downloading.

What do you think?

Reply
Revision history for this message
Damon Lynch (dlynch3) wrote :

It would be much better to preview the image in the application itself by double clicking on the thumbnail. It's been on the TODO list for a long time, but is a low priority compared to other tasks. It has not been written.

Reply
Revision history for this message
Łukasz Dziedziul (ldziedziul) wrote :

Yes, agree but on the other hand, it's better to have a working preview with an external program than nothing, especially if it's a low priority task.

The change could be done incrementally:
- add external preview right now
- when internal preview is ready: add new "default preview mode" setting: external or internal.

Reply

Unmerged revisions

1116. By Łukasz Dziedziul

open selected file in xfce instead of parent directory

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'raphodo/constants.py'
2--- raphodo/constants.py 2018-10-19 03:34:16 +0000
3+++ raphodo/constants.py 2018-12-23 19:03:40 +0000
4@@ -510,7 +510,7 @@
5 nautilus=FileManagerType.regular,
6 dolphin=FileManagerType.select,
7 caja=FileManagerType.dir_only_uri,
8- thunar=FileManagerType.dir_only_uri,
9+ thunar=FileManagerType.regular,
10 nemo=FileManagerType.regular,
11 pcmanfm=FileManagerType.dir_only_uri,
12 )

Subscribers

People subscribed via source and target branches