Code review comment for lp:~lazypower/charms/trusty/mongodb/charmhelpers_merge

Revision history for this message
Cory Johns (johnsca) wrote :

Charles,

With the fixes as we discussed on IRC, I give this refactor my +1.

The tests all pass, with the caveat mentioned above (which will be resolved once it is merged), and the charm is overall cleaner. I particularly like the pattern for pulling in charm_helpers_sync.py and wonder if that could be leveraged into a pattern for pulling in charmhelpers at deploy time.

review: Approve

« Back to merge proposal