Juju Charms Collection
flannel-docker package

Code review comment for lp:~lazypower/charms/trusty/flannel-docker/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Greetings Charles!

Thanks for the latest fixes to the flannel-docker charm! The ansible code
change looks safe and logical. I ran this latest
code on our CI system and saw it pass on Azure, HP, and Joyent. I also
deployed the scenario that you listed in the description which worked fine.

I merged your changes with the exising flannel-docker charm. Thank you for
this quality submission!

review: Approve

« Back to merge proposal