Juju Charms Collection
elasticsearch package

Merge lp:~lazypower/charms/trusty/elasticsearch/exit-messaging into lp:charms/trusty/elasticsearch

  1. Trusty Tahr (14.04)
  2. exit-messaging
  3. Merge into trunk
Proposed by Charles Butler
Status: Merged
Merged at revision: 46
Proposed branch: lp:~lazypower/charms/trusty/elasticsearch/exit-messaging
Merge into: lp:charms/trusty/elasticsearch
Diff against target: 22 lines (+15/-0)
1 file modified
playbook.yaml (+15/-0)
To merge this branch: bzr merge lp:~lazypower/charms/trusty/elasticsearch/exit-messaging
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Approve
Marco Ceppi (community) Approve
Review via email: mp+304824@code.launchpad.net

Description of the change

Adds exit messaging to key hook invocations to keep the user messaging crisp.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM +1

review: Approve
Revision history for this message
Matt Bruzek (mbruzek) wrote :

It passes proof, it merged cleanly. It is the only difference between it and the current charm, and it deploys with "Ready" as status message.

+1 Well done sir.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'playbook.yaml'
2--- playbook.yaml 2015-10-27 22:23:15 +0000
3+++ playbook.yaml 2016-09-02 18:54:23 +0000
4@@ -78,3 +78,18 @@
5 - data-relation-changed
6 - data-relation-departed
7 - data-relation-broken
8+
9+ # A bug in the ansible hooks() helper requires at least
10+ # one task to be tagged.
11+ - name: Set exit user messaging.
12+ command: >
13+ status-set
14+ active
15+ Ready
16+ tags:
17+ - client-relation-joined
18+ - client-relation-departed
19+ - peer-relation-joined
20+ - peer-relation-departed
21+ - start
22+

Subscribers

People subscribed via source and target branches