Merge lp:~lazypower/charms/trusty/docker/i-hate-bzr into lp:charms/trusty/docker
Status: | Work in progress |
---|---|
Proposed branch: | lp:~lazypower/charms/trusty/docker/i-hate-bzr |
Merge into: | lp:charms/trusty/docker |
Diff against target: |
200 lines (+74/-37) 7 files modified
Makefile (+1/-1) README.md (+20/-2) config.yaml (+9/-1) hooks/setup.py (+0/-22) hooks/setup.sh (+0/-9) playbooks/config-changed.yaml (+31/-0) tests/10-deploy-test (+13/-2) |
To merge this branch: | bzr merge lp:~lazypower/charms/trusty/docker/i-hate-bzr |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matt Bruzek (community) | Needs Fixing | ||
Review via email: mp+265462@code.launchpad.net |
Description of the change
Updates to v0.1.6 of the docker charm, which adds AUFS backend storage support.
The existing charm deploys device mapper, leaving this enabled by default is not desireable as Docker Inc has depreciated support for this storage engine. Its possible to upgrade existing clusters, however the upgrade path takes some manual intervention of exporting and re-importing the containers.
This has potential side-effects for data-containers, and existing services which will prevent them from starting. Full export and recovery instructions are included in the README along with validation of AUFS storage driver from a devicemapper upgrade have been included in the test suite.
Unmerged revisions
- 8. By Charles Butler
-
Removes local charm from test
- 7. By Charles Butler
-
Fresh tree to deal with BZRs inconsistent lack of brain cells
This branch seems to merge successfully, I think you have mastered bzr.
I like the changes in made in this pull request, but the tests do not pass on bundletester on azure or kvm.
Issue #1: There may be something wrong with the way you install charm-tools. Running "make lint" fails with "SyntaxError: invalid syntax". I created a bug about this problem: https:/ /bugs.launchpad .net/charm- tools/+ bug/1477194
This error may be related to your use of tox or how you install charm-tools. I was able to "pip install charm-tools" in another virtualenv WITHOUT any Syntax errors.
Issue #2: The docker daemon does not start on the unit. At the end of the tests I expect to see the docker daemon running on the unit and it is not.
Issue #3: I believe the test that checks for version 1.7.0 needs a sleep after the wait. I have created a merge proposal for this branch https:/ /code.launchpad .net/~mbruzek/ charms/ trusty/ docker/ sleep5/ +merge/ 265554 with my suggestion.