Code review comment for lp:~lazypower/charms/precise/nrpe/fix-lp-1287393

Revision history for this message
Matt Bruzek (mbruzek) wrote :

This change needs more information.

Add a comment to make it more clear what IP address the code is trying to get. The new code gets the unit address rather than the relation address (which I realize may be the same one).

Since there appears to be a possiblity of getting an empty address. Either fall back to the old way of getting the address or log a warning, or error if the address resolves to an empty string.

review: Needs Information

« Back to merge proposal