Code review comment for lp:~laurynas-biveinis/percona-server/fake-changes-from-fb-5.6

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> thr_get_trx expects that thr is NULL

(_not_ NULL)

You are right, thanks, I have reviewed and updated accordingly.

> btr0cur.cc line 2397, btr_cur_optimistic_update
>
> line 2260:
> ut_ad(thr_get_trx(thr)->id == trx_id
> || (flags & ~(BTR_KEEP_POS_FLAG | BTR_KEEP_IBUF_BITMAP))
> == (BTR_NO_UNDO_LOG_FLAG | BTR_NO_LOCKING_FLAG
> | BTR_CREATE_FLAG | BTR_KEEP_SYS_FLAG));
> is either bug or thr should never be NULL here

Thanks, http://bugs.mysql.com/bug.php?id=69847.

review: Needs Fixing

« Back to merge proposal