Merge lp:~laurynas-biveinis/percona-server/bug902471 into lp:percona-server/5.1
| Status: | Merged |
|---|---|
| Approved by: | Alexey Kopytov |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 479 |
| Proposed branch: | lp:~laurynas-biveinis/percona-server/bug902471 |
| Merge into: | lp:percona-server/5.1 |
| Diff against target: |
11 lines (+1/-1) 1 file modified
Percona-Server/extra/yassl/taocrypt/src/Makefile.am (+1/-1) |
| To merge this branch: | bzr merge lp:~laurynas-biveinis/percona-server/bug902471 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexey Kopytov (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix bug 902471 (Lots of ssl tests failures on oneiric hosts), which is
upstream bug http://
The crashes are caused by broken inline assembly in taocrypt, that
does not properly pass function args to the inline assembly using the
GCC extended asm syntax, but rather assumes a certain stack layout.
This is not exposed to the compiler and breaks with GCC upgrade and/or
different optimization options.
Workaround by adding -fno-omit-
compilation flags, thus forcing the required stack layout. This is
not a proper fix, and might break in the future again.
Jenkins: http://
Null-merge for 5.5 (inline assembly there is broken too, but 5.5 does not crash. Since we only workaround and not fix, 5.5 is good enough already).
| Alexey Kopytov (akopytov) | # |
