Merge lp:~laurynas-biveinis/percona-server/bug884819 into lp:percona-server/5.5

Proposed by Laurynas Biveinis
Status: Rejected
Rejected by: Laurynas Biveinis
Proposed branch: lp:~laurynas-biveinis/percona-server/bug884819
Merge into: lp:percona-server/5.5
Diff against target: 24 lines (+12/-0)
2 files modified
patches/bug884819.patch (+11/-0)
patches/series (+1/-0)
To merge this branch: bzr merge lp:~laurynas-biveinis/percona-server/bug884819
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Disapprove
Review via email: mp+80993@code.launchpad.net

Description of the change

Fix bug 884819 (upstream bug 60745): the dialog plugin is compiled to
binary named auth.so. Binary name stem differing from the plugin name
makes the plugin unloadable.

Fixed by changing the binary name back to dialog.so.

NOT tested by Jenkins on purpose; tested by building, inspecting build output, verifying that dialog plugin loads.

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Will fix in percona-pam-for-mysql project in another way, sorry for the spam.

review: Disapprove

Unmerged revisions

193. By Laurynas Biveinis

Fix bug 884819 (upstream bug 60745): the dialog plugin is compiled to
binary named auth.so. Binary name stem differing from the plugin name
makes the plugin unloadable.

Fixed by changing the binary name back to dialog.so.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'patches/bug884819.patch'
2--- patches/bug884819.patch 1970-01-01 00:00:00 +0000
3+++ patches/bug884819.patch 2011-11-02 10:19:25 +0000
4@@ -0,0 +1,11 @@
5+--- a/plugin/auth/CMakeLists.txt
6++++ b/plugin/auth/CMakeLists.txt
7+@@ -14,7 +14,7 @@
8+ # along with this program; if not, write to the Free Software
9+ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
10+
11+-MYSQL_ADD_PLUGIN(auth dialog.c
12++MYSQL_ADD_PLUGIN(dialog dialog.c
13+ MODULE_ONLY)
14+ MYSQL_ADD_PLUGIN(auth_test_plugin test_plugin.c
15+ MODULE_ONLY)
16
17=== modified file 'patches/series'
18--- patches/series 2011-10-13 09:13:42 +0000
19+++ patches/series 2011-11-02 10:19:25 +0000
20@@ -59,3 +59,4 @@
21 xtradb_bug317074.patch
22 subunit.patch
23 bug860910.patch
24+bug884819.patch

Subscribers

People subscribed via source and target branches