lp:~laurynas-biveinis/percona-server/bug805805-1060136-1061118-5.1

Branch merges

Propose for merging

No branches dependent on this one.

Superseded for merging into lp:percona-server/5.1

Alexey Kopytov (community): Needs Fixing on 2012-10-05

Diff: 134 lines (+39/-6)

6 files modified

Percona-Server/configure.in (+6/-0)
Percona-Server/mysql-test/lib/My/SafeProcess/safe_process.cc (+4/-1)
Percona-Server/mysql-test/r/percona_signal_handling.result (+3/-0)
Percona-Server/mysql-test/t/percona_signal_handling.test (+8/-0)
Percona-Server/sql/net_serv.cc (+6/-2)
Percona-Server/vio/viosocket.c (+12/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #805805: attaching to percona-server with gdb disconnects clients	High	Fix Released
Bug #1060136: safe_process.cc/safe_process.pl should not kill mysqld on SIGSTOP/SIGCONT	Undecided	Fix Released

Link a bug report

Related blueprints

484. By Laurynas Biveinis on 2012-10-04

Fix:
- bug 1060136 (safe_process.cc/safe_process.pl should not kill
  mysqld on SIGSTOP/SIGCONT);
- bug 1061118 (Patch to remove excessive fcntl() calls was never
  ported correctly to 5.1);
- bug 805805 (attaching to percona-server with gdb disconnects
  clients).

These bugs are fixed together because fixing bug 1061118 exposes bug
805805, and the testcase for the latter requires bug 1060136 to be
fixed.

For bug 1060136, the issue is that safe_process.cc is setup to kill
the child on SIGCHLD signal. But this signal may be raised when child
receives non-killing signals too, such as SIGSTOP/SIGCONT, resulting
in safe_process killing the child on such signals too. Fixed by
limiting SIGCHLD only to killing signals, by specifying the
SA_NOCLDSTOP option.

For bug 1061118, the issue is that the fcntl()-removing patch is
dependant on NO_ALARM C preprocessor define being defined. But
nothing in the build defined it. Fixed by adding it to configure.in.
If Percona Server suppported more platforms, a better fix would be to
backport SO_SNDTIMEO/SO_RCVTIMEO checks from 5.5, but at this point in
5.1 lifecycle an unconditional define is enough. In addition to
NO_DEBUG, we also define SIGNAL_WITH_VIO_CLOSE to follow 5.5. If the
latter is not defined, percona_innodb_kill_idle_trx* tests regress by
server returning query execution interrupted error instead of closing
the socket. To avoid regressing on upstream bug
http://bugs.mysql.com/bug.php?id=52633 (When building with -DNO_ALARM
on Linux, wait_timeout is effective 10x longer), backport its
vio_should_retry() too. This same backport is used by the Facebook
5.1 branch.

For bug 805805, the issue is that mysqld (with fcntl()s removed,
i.e. the above fixed) will close the the connections upon receiving
SIGSTOP/SIGCONT. This is caused by network read from socket being
cancelled with errno = EINTR on these signals. Normally this is
handled by my_real_read() retrying the read on EINTR, but the
fcntl()-removal patch has disabled this inadvertently in
my_real_read() and my_real_write(). Added a testcase
percona_signal_handling.

483. By Stewart Smith on 2012-10-02

merge fix for: Bug #1046389: UNIV_DEBUG build broken

482. By Hrvoje Matijakovic on 2012-09-25

Merged lp:~hrvojem/percona-server/bug1034305-5.1

481. By Stewart Smith on 2012-09-05

merge 5.1.65-14.0 release branch

480. By Stewart Smith on 2012-09-05

merge Bug #747032: Flashcache throws an error on startup when flashcache is not used

479. By Stewart Smith on 2012-09-05

merge fix for Bug #902471: Lots of ssl tests failures on oneiric hosts

478. By Stewart Smith on 2012-09-05

merge fix for Bug #1039931: 64-bit atomic operation Autoconf tests duplicated in regular atomic operation tests

477. By Hrvoje Matijakovic on 2012-09-03

Merged lp:~hrvojem/percona-server/rn-5.1.65-14.0

476. By Stewart Smith on 2012-08-27

merge fix for Bug #902472: main.subselect_notembedded fails on Ubuntu Oneiric in Jenkins

475. By Stewart Smith on 2012-08-27

merge fix for Bug #1023883: libmysqlclient16-dev 'Replaces' libmysqlclient16-dev but doesn't 'Provides' it